search

RP-Kit / RPKit

RPKit plugin suite
Apache License 2.0
21 stars 12 forks source link

Private messages sometimes do not send #584

Closed renbinden closed 2 years ago

renbinden commented 2 years ago

There are a few permissions lookups & player lookups in the message command that may not succeed when run outside of the main thread. thenAccept does not guarantee the thread that the block will be run on the main thread, therefore pm should schedule a sync task to perform these actions: https://github.com/RP-Kit/RPKit/blob/main/bukkit/rpk-chat-bukkit/src/main/kotlin/com/rpkit/chat/bukkit/command/message/MessageCommand.kt#L60

Additionally adding the participants to the chat group sometimes does not complete before sending the message.

renbinden commented 2 years ago

This will be backported to 2.0 and 2.1 in addition to being fixed in 2.2 as there are still servers using MC1.16 & MC1.17 that require the fix.