search

RP6conrad / ESP-GPS-Logger

GPS logger for Speedsurfing, based on ESP32 & Ublox M8N hardware.
MIT License
28 stars 16 forks source link

Fractional hour time zones #14

Closed prichterich closed 1 year ago

prichterich commented 1 year ago

The web configuration interface should support fractional time zones. I'm currently at Lake George in South Australia (with a few dozen other speedsurfers), and the time zone is UTC +10:30. Western Australia also has a time zone that is UTC +8:45. Currently, the box for time zone seems to allow only integers.

RP6conrad commented 1 year ago

I will change the timezone variable from int -> float, but the user has to account for : +1:30"- = +1.5 correction !! +8:45 = +8.75 correction !!

prichterich commented 1 year ago

Using a float is the easiest solution for programming, but it will certainly confuse many users. The same will be true for using minutes. Another disadvantage for both is that users can enter invalid values.

I would suggest to spend some extra time and present the allowed choices as a drop-down menu, similar to the way you can set the time zone in the GPS Speedreader preferences. This adds some coding overhead, but that is a one-time effort that users will benefit from forever.

RP6conrad commented 1 year ago

Will go that direction (drop down menu with all timezones). What about daylight saving, is that an issue in these partial timezones ?

prichterich commented 1 year ago

Of the time zones with fractional hour offsets, the only one I have seen lots of postings of is South Australia (+9:30). There is an entry in Speedreader's drop down that works for summer time (+10:30 Australia/LHI). There are a few other regions in Asia and the Pacific, and one in Oz (Eucla) that have fractional time zones, but I don't think speedsurfing is popular there, and some zones (like Australia / Eucla) do not use summer time. Theoretically, you could add an extra checkbox for summer time, or even try to determine automatically if it applies, but I think that's overkill.

RP6conrad commented 1 year ago

Timezone choice with drop down menu in now in latest SW 5.73.