search

RP6conrad / ESP-GPS-Logger

GPS logger for Speedsurfing, based on ESP32 & Ublox M8N hardware.
MIT License
28 stars 16 forks source link

Date and time wrong in GPY files #33

Open prichterich opened 1 month ago

prichterich commented 1 month ago

In version 5.85, the date and time is wrong in .gpy files. With a time zone of GMT-4, the error is -40 hours. The error was not present in version 5.82 (which I suggest to remove from the BIN downloads since both buttons and AP functions do not work properly).

The attached zip archive contains pairs of small .ubx and .gpy files created with different software versions on 8/10/24, between 10 and 11:40 am EDT. Only the .gpy files created with version 5.85 show the wrong date (8/8 instead of 8/10) and the wrong time (16 hours too early). The .ubx files all have the correct date and time. The gpy.h files on GitHub does not show any recent changes that would explain the difference (last change: last year is shown).

GPY_error.zip

RP6conrad commented 1 month ago

There is indeed a big error in some timezones. This has been introduced with the DST correction. In the gpy.h file is also a error, as I use mktime() function for UTC timestamp. This function returns localtime, but I need UTC time... Will be corrected in the next update....

Thanks for reporting this error !

Greetings, Jan

Van: prichterich @.> Verzonden: zaterdag 10 augustus 2024 17:57 Aan: RP6conrad/ESP-GPS-Logger @.> CC: Subscribed @.***> Onderwerp: [RP6conrad/ESP-GPS-Logger] Date and time wrong in GPY files (Issue #33)

In version 5.85, the date and time is wrong in .gpy files. With a time zone of GMT-4, the error is -40 hours. The error was not present in version 5.82 (which I suggest to remove from the BIN downloads since both buttons and AP functions do not work properly).

The attached zip archive contains pairs of small .ubx and .gpy files created with different software versions on 8/10/24, between 10 and 11:40 am EDT. Only the .gpy files created with version 5.85 show the wrong date (8/8 instead of 8/10) and the wrong time (16 hours too early). The .ubx files all have the correct date and time. The gpy.h files on GitHub does not show any recent changes that would explain the difference (last change: last year is shown).

GPY_error.ziphttps://github.com/user-attachments/files/16570129/GPY_error.zip

— Reply to this email directly, view it on GitHubhttps://github.com/RP6conrad/ESP-GPS-Logger/issues/33, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOBIYSZFP3KW735CU4WJSZLZQYZ6BAVCNFSM6AAAAABMJ55TG6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2TSMJUGUYTMOA. You are receiving this because you are subscribed to this thread.Message ID: @.***>

RP6conrad commented 1 month ago

Corrected version SW 5.87 is on github. Error was in the TZ (timezone) string, 4 h offset was seen as 40h, and in the gpy file, the local time (40h difference with UTC) was stored in the frames...

Greetings, Jan.

Van: prichterich @.> Verzonden: zaterdag 10 augustus 2024 17:57 Aan: RP6conrad/ESP-GPS-Logger @.> CC: Subscribed @.***> Onderwerp: [RP6conrad/ESP-GPS-Logger] Date and time wrong in GPY files (Issue #33)

In version 5.85, the date and time is wrong in .gpy files. With a time zone of GMT-4, the error is -40 hours. The error was not present in version 5.82 (which I suggest to remove from the BIN downloads since both buttons and AP functions do not work properly).

The attached zip archive contains pairs of small .ubx and .gpy files created with different software versions on 8/10/24, between 10 and 11:40 am EDT. Only the .gpy files created with version 5.85 show the wrong date (8/8 instead of 8/10) and the wrong time (16 hours too early). The .ubx files all have the correct date and time. The gpy.h files on GitHub does not show any recent changes that would explain the difference (last change: last year is shown).

GPY_error.ziphttps://github.com/user-attachments/files/16570129/GPY_error.zip

— Reply to this email directly, view it on GitHubhttps://github.com/RP6conrad/ESP-GPS-Logger/issues/33, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOBIYSZFP3KW735CU4WJSZLZQYZ6BAVCNFSM6AAAAABMJ55TG6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2TSMJUGUYTMOA. You are receiving this because you are subscribed to this thread.Message ID: @.***>