search

RPCS3 / discord-bot

Source code for RPCS3's Discord bot.
https://rpcs3.net/
GNU Lesser General Public License v2.1
58 stars 45 forks source link

Linking/Referencing merged PR's should link to old master build when the PR merged rather than latest #860

Closed Asinin3 closed 1 year ago

Asinin3 commented 2 years ago

Currently, when you mention a old PR via URL or #PRNumber the download links go to the latest master build of RPCS3, instead of the master build when the PR merged. image I would like this to change to instead link to the build when the PR merged, and have a warning about how it is an older build. To improve upon this, there could be a link to the master build directly BEFORE the mentioned PR merged. So you could link e.g #11607 and get a link to when the Surface Cache PR merged, and the build directly before it. Saving tons of time searching the build history page.

Closes #814

Darkhost1999 commented 2 years ago

image Still an annoying issue that created problems in help too. I remember this linking to https://api.cirrus-ci.com/v1/artifact/task/4562251708366848/Artifact/rpcs3-v0.0.23-13cec72b_win64.7z or the applicable PR in the past. Maybe thats just me though confusing merged and unmerged PRs

13xforever commented 1 year ago

Binaries were always linked to the current master build

13xforever commented 1 year ago

I don't want randoms looking for old pr numbers to get old builds, so default behavior will stay as it is now. But in case someone wants to link old build on purpose, I've implemented !pr link XXX command that will link old build.