search

RPCS3 / discord-bot

Source code for RPCS3's Discord bot.
https://rpcs3.net/
GNU Lesser General Public License v2.1
58 stars 45 forks source link

Thread scheduler recommendation #910

Open Darkhost1999 opened 1 year ago

Darkhost1999 commented 1 year ago

If it's not recommended to use a thread scheduler unless you have 12+ threads then we probably should avoid recommending it to those who can't use the option.

https://github.com/RPCS3/rpcs3/blob/master/rpcs3/rpcs3qt/tooltips.h#L86

Screenshot

Just a thought honestly. If fewer than 12 threads don't print out the message that thread scheduler may improve performance as it may just make things worse and they'll probably disregard the tooltip thinking "The bot told me it was ok" [The image is just an example I took from the last log I saw when thinking about this]

13xforever commented 1 year ago

That's only relevant for Intel CPUs, and there's already check for that

Asinin3 commented 1 year ago

Huh? The thread scheduler is only relevant for AMD, not Intel.