RPCS3 / discord-bot

Source code for RPCS3's Discord bot.
https://rpcs3.net/
GNU Lesser General Public License v2.1
58 stars 45 forks source link

IRD verification on log is not reliable if game version differs #942

Open AniLeo opened 12 months ago

AniLeo commented 12 months ago

See discussion here: https://github.com/RPCS3/rpcs3/issues/14231#issuecomment-1696242432

13xforever commented 11 months ago

IRD check does what it can. Game updates can't remove files, only add. We cross-check the missing files from log errors with paths in IRD disc TOC section, and only report the game as broken when we expect the file to be present on disc. There are some rare examples when IRDs were wrong, or disc content is different even when all versions in metadata are the same. But that's why you have humans to double check.

If there are specific popular games/versions, we can check for that separately.