search

RPCS3 / rpcs3

PS3 emulator/debugger
https://rpcs3.net/
GNU General Public License v2.0
15.21k stars 1.9k forks source link

[Feature Request] Trophy pop-up sound #10427

Closed Kilowog01 closed 2 years ago

Kilowog01 commented 3 years ago

I would like to hear sound in the trophy notification. Trophies are a reward, often for a very large effort. And at the moment the RPCS3 notification does not transmit this sensation of reward, it is hollow, lifeless, lack magic, lacks...sound.

Details

  1. User loads PS3 firmware
  2. RPCS3 extracts the trophy notification sound from dev_flash\vsh\resource\system_plugin.rco
  3. When the pop-up is called -> PlaySound (Snd_trophy.wav)
  4. Boom, trophies are 500% better now

Parts of RPCS3 that would be affected by this feature:

marcoluc97 commented 2 years ago

See #11078 for this change @Megamouse like asked in #10482 the last things remain but still optional are:

As always good work!

Hasster1 commented 2 years ago

Shouldn't this be closed now?

Darkhost1999 commented 2 years ago

The only thing missing from the feature request I believe is .rco extraction to the sound folder. Which isn't that a legal concern? The current noise is a QT beep right? Unless you upload your own sound named appropriately. So are we waiting for someone to make a playlist of sounds?

Megamouse commented 2 years ago

Yes

poudink commented 2 years ago

Legal concern how? Wouldn't the sound be extracted automatically by RPCS3 from the user provided firmware, as proposed by the first post? What's the legal concern here? It's not like RPCS3 would be distributed with the sound.

Megamouse commented 2 years ago

I'd say this is implemented. I don't know if someone wrote a tutorial, but you need to copy some file to some dir and then it works.

Decrypting random fw files seems out of scope for this issue.