search

RPCS3 / rpcs3

PlayStation 3 emulator and debugger
https://rpcs3.net/
GNU General Public License v2.0
15.43k stars 1.92k forks source link

[Feature Request] Add FXAA pass #10902

Open Nerboruto opened 3 years ago

Nerboruto commented 3 years ago

Quick summary

To improve in general image quality and FSR pass

Details

it must be implemented before scaling to native ps3 resolution and a button in the gui to enable it

Nerboruto commented 3 years ago

in case I can try to implement it myself if KD-11 has no time.

Asinin3 commented 3 years ago

I know kd planned on eventually adding a way to force msaa and also make it run faster. FXAA makes things a blurry so im not sure how much people would want it. But additions are always welcome. Personally I like SMAA quite a lot.

Linear524 commented 3 years ago

FSR doesn't need FXAA tech addition because FSR itself based on Lanczos for upscaling image while sharpening is being applied at designated level. FXAA will just mess up high-contrasted details. Original PS3 uses MLAA on SPU cores and it more than enough for PS3 games under 720p resolution. So MLAA + 720p + 16AF + current FSR upscaling = is the best option for RPCS3. The only thing left here - fix remaining MLAA shader error in RPCS3 and that is all.

Asinin3 commented 3 years ago

Not all games use MLAA you know.

Nerboruto commented 3 years ago

Mlaa in spu kill performance.. fxaa on luma Is very fast and solve AA problems. i'm doing tests with fxaa and it works fine without damaging the image

720p-1080pfxaa

Linear524 commented 3 years ago

Not all games use MLAA you know.

Not all - yes. But a lot of important games: God of War 3, Ascention, Killzone 2,3, Last of Us, Uncharted 2,3, Persona 5, MGS 2,3,PW, Shadow of the Colossus, Ico, and a lot of other games. FXAA is side addition and will make crappy image, just like reShade does with RPCS3. MLAA is slower but 100% accurate because it was programmed by game developers in their titles on PS3. For example - try God of war 3 with 720p + 16AF + FSR without any patches = it will give accurate and nice picture. And then try this title with MLAA disabling patch + upscaling and check overal image - it will be missing a lot of nice post-op effects and will looks like oversharpen bright crap. Sure MLAA-disabling patches brings some speedup, but also cuts off a lot of effects with color processing, filters and other important stuff.

floppyD commented 7 months ago

I've been injecting SMAA with ReShade since it helps quite a lot even if you are using resolution scaling, but I do wish there was an official implementation.

MaxMo20 commented 2 months ago

I know kd planned on eventually adding a way to force msaa and also make it run faster. FXAA makes things a blurry so im not sure how much people would want it. But additions are always welcome. Personally I like SMAA quite a lot.

I heard this, any news on msaa? I would love an fxaa and or smaa pass on msaa, though smaa seems to not work well with msaa but maybe RPCS3 can find away to get that working?

Edit: Kinda out of the loop on RPCS3 information but there doesn't seem to be much new info to begin with.