RPCS3 / rpcs3

PlayStation 3 emulator and debugger
https://rpcs3.net/
GNU General Public License v2.0
15.43k stars 1.92k forks source link

CFW-style split-file reading not working #11238

Open AniLeo opened 2 years ago

AniLeo commented 2 years ago

https://github.com/RPCS3/rpcs3/blob/c52d44738197069585affe85db45e1e94c1d9516/rpcs3/Emu/Cell/lv2/sys_fs.cpp#L473

There's some code related to files split by multiman when dumping, RPCS3 tries finding split files when the original file is CELL_ENOENT, but games with split files currently do not work correctly (for example, MGS4).

RPCS3 should either not try to read these files at all like OFW and/or throw a warning if one is detected asking users to merge their games, or the file reading code needs to be completed so it works.

You can reproduce a bug here by having split files on MGS4 disc dump and booting the game to menu. It will deadlock and you won't be able to send input and go past the menu. It will work if you merge the split files.

elad335 commented 2 years ago

No log no slog. A new catchphrase.

AniLeo commented 2 years ago

Filed from user reports, I don't have a file split MGS4 right now otherwise I'd have added one myself, will have to wait a bit until someone provides one or I dump my disc again with split files, hopefully soon.

B1ackDaemon commented 2 years ago

It comes from OFW filesystem limitation for external usb drives - only FAT32, e.t. workaround for games with files >4Gb [so they have to split big gamedata files to <4Gb parts], internal HDD doesn't have this problem. COBRA payload supports NTFS tho, but it's rather an exception.