RPCS3 / rpcs3

PS3 emulator/debugger
https://rpcs3.net/
GNU General Public License v2.0
15.21k stars 1.9k forks source link

Games do not boot after #11178 #11360

Closed MSuih closed 2 years ago

MSuih commented 2 years ago

After PR #11178 was merged path handling got broken in some way. Booting any disc game with it just shows "Booting failed: The selected file or folder is invalid or corrupted." error, and booting any HDD game makes emulator close after loading caches.

broken_disc.RPCS3.log.gz broken_hdd.RPCS3.log working.RPCS3.log.gz

Tested on windows, have gotten confirmation that linux is unaffected. The previous version (which was rollbacked on rpcs3.net/downloads) works fine.

MSuih commented 2 years ago

To elaborate further, disc games seem to be missing last part of path:

Invalid disc directory for the disc game BLUS30464. (D:\Emulaattori\Pelit\PS3\Skate 3PS3_DISC.SFB)

This should have a backslash between Skate 3 folder and PS3_DISC.SFB file.

For HDD games, it finds the game but seems to fall apart when trying to create llvm modules:

LLVM: Failed to create module file: D:/Emulaattori/RPCS3/cache/NPUB30051/ppu-UMeENWzxQ2JeUEYMu0F1C0SPz1tX-D:\Emulaattori\RPCS3\dev_hdd0\game\NPUB30051\USRDIREBOOT.BIN/v5-kusa-WZNb4YM3dk1CRgTv8bVf2a-00000G-znver2.obj.gz (Invalid arguments)

The path starts from beginning in middle of the message.

I don't know if there are more path errors beyond these lines.

Darkhost1999 commented 2 years ago

Digital games still show Dev_hdd0/game//USRDIR 1 too many /

Darkhost1999 commented 2 years ago

My previous comment was based off screenshot and log in discord of version 13174 https://discord.com/channels/272035812277878785/277227681836302338/930945225046777916 However, my test seems to work just fine on my pc. RPCS3.log My PKG comes from a PKGDIR on the disc of Bioshock infinite.

kd-11 commented 2 years ago

Closing as fixed by https://github.com/RPCS3/rpcs3/pull/11370

MSuih commented 2 years ago

Yes, seems to have fixed the issues

DemetriussXVII commented 1 year ago

I started facing the same issue as of the latest updates, my old games work fine but any new game I try whether it's a disc or PKG give me the exact same error.