search

RPCS3 / rpcs3

PlayStation 3 emulator and debugger
https://rpcs3.net/
GNU General Public License v2.0
15.69k stars 1.93k forks source link

Remaining graphical issues in Saints Row: The Third #11725

Open MarioSonic2987 opened 2 years ago

MarioSonic2987 commented 2 years ago

Update (20/1/2024): Enabling WCB and RCB fixes broken water on the distance. Update (24/9/2022): OpenGL regression is fixed.

Quick summary

Broken water reflections in Vulkan. Needs Write Color Buffers and Read Color Buffers to fix this glitch.

Details

If you use Vulkan, it has broken water reflections. Anisotropic filter set to 16x improves a little bit.

Configuration needed

It needs Write Color Buffers enabled and Vertex Cache disabled to fix missing 3D graphics and the Map menu UI, respectively.

Log

Log

Screenshots

image

RSX captures

Lighting Vulkan Water Vulkan

Specs:

Savedata

Savedata

MarioSonic2987 commented 2 years ago

Saints Row: Gat out of Hell throws this fatal error when using OpenGL:

Unhandled GL format 0x83F1
(in file D:\a\1\s\rpcs3\Emu\RSX\GL\GLHelpers.h:1504[:26], in function texture)

Log OpenGL

Edit: Fixed.

MarioSonic2987 commented 2 years ago

0.0.20-13232 (PR #11445) was the last build with correct graphics on OpenGL. image

0.0.20-13234 (PR #11443) there was a crash. It couldn't get ingame with OpenGL.

0.0.20-13282 (PR #11525) fixed that crash. Graphics were regressed. image

nitroos-ai commented 2 years ago

Try #11833

MarioSonic2987 commented 2 years ago

PR #11833 fixes crashing in Saints Row: Gat out of Hell. Graphics are still broken.

MarioSonic2987 commented 2 years ago

PR #12020 makes Saints Row games crash randomly when going ingame with no fatal error. Log Gat out of Hell Broken

MarioSonic2987 commented 2 years ago

In 0.0.23-13883, crashes are no longer present.

MarioSonic2987 commented 2 years ago

Broken graphics in OpenGL are fixed in 0.0.24-14175. image image

MarioSonic2987 commented 1 year ago

As of 0.0.28-15212, distant water reflection is now fixed, although it's now flickering in Vulkan. However, water is now waving weirdly when you're close to it.

Vulkan: https://github.com/RPCS3/rpcs3/assets/20027681/a49d2302-321d-4d92-86a1-e3e87cdd02b0

OpenGL: https://github.com/RPCS3/rpcs3/assets/20027681/21a6c040-de5f-4a18-aaf8-5a2c3d2a64da

EDIT: Saints Row IV is not affected.

MarioSonic2987 commented 1 year ago

Some elements are drawn through the objects, like the lights on the plane in the beginning of the game. Same with Saints Row IV and Gat out of Hell.

RPCS3: BugSRTT

PS3: image

They are also present on vehicle headlights. image

MarioSonic2987 commented 10 months ago

Enabling Write Color Buffers and Read Color Buffers fixes water on the distance. image

Write Color Buffers only: image

The shaking water bug is still present:

https://github.com/RPCS3/rpcs3/assets/20027681/ae644525-7eda-4343-beed-b77c569ff7f5

kd-11 commented 10 months ago

The shaking water bug is still present:

BLES01747_recording_2024_01_20_15_05_16.mp4

First thing to check there would be SPU options. Whenever I see weird calculations breaking animation it's almost always some SPU magic.

MarioSonic2987 commented 10 months ago

When using SPU ASMJIT, water flickers A LOT more than with SPU LLVM (Approximate XFloat). The same happens with SPU LLVM (Accurate XFloat).

https://github.com/RPCS3/rpcs3/assets/20027681/09b385f2-9ae8-4d85-9fea-f20d086a27b1

SPU LLVM (Approximate XFloat):

https://github.com/RPCS3/rpcs3/assets/20027681/b82ebfca-e32d-4948-b7b9-17d2c37ff215

MarioSonic2987 commented 6 days ago

When you press Alt+Enter to toggle fullscreen many times, the water breaks even more.

No Alt+Enter (water is still shaking): image

Pressing Alt+Enter more than 3 times (water has vertex explosions): image