elad335
commented
2 years ago Test #12464
Closed jedinjapan closed 2 years ago
elad335
commented
2 years ago Test #12464
jedinjapan
commented
2 years ago Test #12464
In testing, appears to resolve issue with Custom Config versus Global Config, and Custom Config parameters are loaded corrected now. (Resolution/ Performance Overlay/ etc)
Based on 30 minutes of mild stress testing in combat zone outside of Advent Palace in Act 1, cellspur patch appears to be loading correctly with the save state as well. In most cases this part of the zone will somewhat consistently crash within 1-2 minutes of combat due to a high frequency of explosions and physics objects otherwise if the patch is not active.
Amazing work and incredibly rapid response to this issue.
elad335
commented
2 years ago Don't close the issue until the pull request is merged.
Quick summary
As it appears to be implemented, the save state feature is not loading a title with custom configurations or patches, and is loading with Global Defaults only.
Details
If a user Boots using custom config, saves state, and resumes, the resumed state will be done under the global default config. This leads to obvious state de-sync issues in some titles, and for some titles requiring custom configuration settings being unable to resume a saved state.
This was tested on NPUB31633 - Metal Gear Solid 4. Under custom configuration the game runs semi-stable when using the recommended cell spur patch. For testing the game was played for 10 minutes before a save state was taken. Upon load, the game rendering resolution dropped drastically, and the title crashed within 20 seconds of gameplay. The test was repeated again, with the same results. The title appeared to have loaded under the global defaults.
The issue is also readily apparent if the Global Default rendering resolution is left at 720p defaults, while the custom resolution scaling is increased on a per-title bases. On load of the save state, the level of visual drop is readily apparent.
This was further verified by then adjusting the Global Rendering resolution and re-loading a backup of the same save state. This extended to all other global settings changed. Additionally, patches do not appear to be loading, and for this particular title this results in crashing due to the cellspurs urgent commands patch being absent when the save state is loaded.
It was suggested that this may be due to RPCS3 failing to identify the game ID upon loading the state, and thus failing to load the appropriate patches and associated custom profile, returning to global defaults.
Attach a log file
RPCS3.log.gz
Attach capture files for visual issues
No response
System configuration
Other details
No response