[Regression] Silent Hill HD Collection - Installing trophies message does not disappear (#11935)

RPCS3 / rpcs3

PlayStation 3 emulator and debugger

https://rpcs3.net/

GNU General Public License v2.0

15.48k stars 1.92k forks source link

[Regression] Silent Hill HD Collection - Installing trophies message does not disappear (#11935) #12862

Closed Jonathan44062 closed 1 year ago

Jonathan44062 commented 2 years ago

Quick summary

Without realizing it, the game is in regression only for this message, it is not removed somehow, but of the games itself, there is no problem, there is only that.

Details

Working - 0.0.22-13565

Regression - 0.0.22-13570 #11935

Build with regression

0.0.22-13570

Attach two log files

Working RPCS3.log.gz

Regression RPCS3.log.gz

Attach capture files for visual issues

None

System configuration

Windows 10 21H2 Intel Core i7-8700 15.93 GiB RAM GPU: NVIDIA GeForce GTX 1070 Ti (516.79)

Other details

No response

Megamouse commented 2 years ago

The issue here is that the game tries to register an non-existing trophy file. The sceNpTrophyRegisterContext function then first calls the statusCallback which contains code to open that progress dialog, and then fails because the file is not found.

It seems logical that we should somehow call the statusCallback with a proper error status again whenever sceNpTrophyRegisterContext fails, in order to give the game a chance to deal with the previously opened dialog.

Megamouse commented 2 years ago

Or it's just missing permissions on the file.

elad335 commented 2 years ago

I think it's because sceNpTrophyCreateContext should fail here, look at commSign.

Jonathan44062 commented 1 year ago

Master:

PR:

Can confirm, this fixes the issue https://github.com/RPCS3/rpcs3/pull/14040