RPCS3 / rpcs3

PS3 emulator/debugger
https://rpcs3.net/
GNU General Public License v2.0
15.13k stars 1.89k forks source link

GUI: Patch creator does not escape control characters #14168

Closed AniLeo closed 3 weeks ago

AniLeo commented 1 year ago
  1. Open Patch Creator
  2. In the notes field, write something with double quotes
  3. Notice the double quotes are added as-is to the final YAML without being escaped like \", this causes the following error when exporting the patch due to broken YAML syntax image
Megamouse commented 1 year ago

Can't reproduce

image

Megamouse commented 1 year ago

oh. the "notes", not the comments

Megamouse commented 1 year ago

This is user error at best. You can even see that it isn't valid in the preview