[Task] RSX tiled memory - remaining work

[kd-11]

General

• [x] Fix leaking paths in FrostBite2 titles e.g NFS Rivals
• [x] Missing effects in split/second at stock
• [x] Fix broken blit resolve (detiling error?) in frostbite where a hall-of-mirrors effect appears (identified)
• [x] GPU ops should operate with a full view of the RSX tiled region. (optimized to require priority regions only)
• [ ] Uploading correct partials results in flickering pixels on screen edges in NFS rivals
• [ ] OpenGL support

CPU-Blit

• [x] CPU blit support
• [x] Fix up support for 16-bit tiling

[legend800]

As someone mentioned in the original PR, Split Second doesn't render explosions/smoke (big part of the game). I just found out that they render ONLY if you use a higher res. But if you do that, then you have mega pixelation issues like this:

So... native res=missing effects higher res=effects render but large pixels (similar to when tiled memory is off)

Settings:

• WCB + RCB + RSX tiled memory
• Strict On (fixes red lines from AF + pixelated gfx from non-native res)
  • or Strict off + AF off + 200% res (pixelated gfx but fixes missing gfx effects) - Log below of this config.

2x - RPCS3.log.gz

[Ordinary205]

The Need for Speed Most Wanted/Hot Pursuit car reflections is fixed by enabling WCB+RSX tiled memory, but the reflections appears inverted. Real PS3:

RPCS3: RPCS3.log.gz

[kd-11]

I reproduced the split second issue. It is likely a codepath issue, since using any scaling including 99% or 101% makes the smoke appear again. I'll debug the real cause later in the week.

[Linear524]

Some bugs to solve for fully working MLAA in Uncharted 3 and TLoU :

Those buggy horizontal lines consist of garbled mask pixels from overall scene - if you move camera a little during those scenes - pixel objects inside those horizontal lines will move as well... Looks like a bit wrong memory sections to read or write MLAA data.

[kd-11]

The stripes should be fixed in the next PR. Actually I probably should just submit that work. I was hoping to knock down a few regressions at once but no need making everything too complicated.

[kd-11]

Test with https://github.com/RPCS3/rpcs3/pull/14706

[Linear524]

@KD-11 TLoU and Uncharted 3 stripes still not fixed with #14706

[kd-11]

Any errors in the log?

[Linear524]

Will try to collect logs today :)

[Linear524]

@KD-11 Nope - nothing in the logs, just standard PPU trampoline spam messages...

[Ordinary205]

Enabling Handle RSX tiling memory partially fixes the other lighting for Army of TWO: The Devil's Cartel, but this causes more rainbow graphics to appear on the left side. WCB+RCB:

WCB+RCB+RSX tiling memory (disabling the MLAA is required to remove yellow graphics): RPCS3.log.gz Testing the PR named "rsx: Detiler improvements" doesn't show any differences.

[Ordinary205]

This PR no longer fixes NFS The Run, and Battlefield 3 now looks like this. RPCS3.log.gz

I think I accidently tested the wrong build which was 15683 instead of 15684, but I'm unable to confirm if this reduces the regression on frostbite games because the windows build is unavailable.

[Ordinary205]

Thanks to illusion for messaging me on discord to get the latest build, I can now confirm that NFS The Run and Battlefield 3 hasn't reverted. RPCS3.log.gz

[Ordinary205]

Enabling RSX tiled memory causes NFS Most Wanted to have more square artifacts to appear on top of the left/right side from the screen. Before: (WCB) RPCS3.log.gz

After: (WCB+RSX tiled memory) RSX tiled memory.gz This issue doesn't happen on NFS hot pursuit.

[kd-11]

This one is a race condition between SPU post-fx pipe and RSX post-fx pipe. The only solution is to speed up SPU code drastically while WCB is active which isn't really feasible without some low-level changes. Something can definitely be done for AMD cards which support device-coherent memory, but for the rest, only faster CPUs will save us. You can also give "Accurate RSX reservations" toggle a try and see if it helps stabilize the issue. This problem already exists in other games such as GT6 as well.

[Ordinary205]

I was testing this game when having Accurate RSX reservations enabled, but sadly it doesn't fix the flickering artifacts with or without that option. RPCS3.log.gz

[Ordinary205]

Enabling RSX tiled memory causes a regression on NFS Hot Pursuit when having read color buffers and asynchronous texture streaming enabled. Before: WCB+RCB+ATS

After: WCB+RCB+ATS+RSX tiled memory

But if I disable the read color buffers or asynchronous texture streaming, the regression is gone. RPCS3.log.gz

[kd-11]

CPU blit is now feature complete as of https://github.com/RPCS3/rpcs3/pull/14934 There are a lot of corner cases when GPU blit is active, I'll try and get those sorted in coming weeks but the limitation is well known (surface and texture cache are separate and don't communicate). I think a lot of corner cases can be handled by replacing the RCB load with a texture cache load+copy (basically a fullscreen quad draw with texture cache as the source). Doing that is easier said than done however.

[Ordinary205]

NFS Most Wanted has stability issues when enabling RCB or RSX Tiled memory before going ingame If I enable RCB with WCB+RSX Tiled memory, the game crashes with this error: WCB+RCB+RSX Tiled memory:

However if I try disabling RCB or RSX Tiled memory, the game works fine and enters ingame successfully. WCB+RSX Tiled memory:

WCB+RCB+RSX Tiled memory: RPCS3.log.gz

[kd-11]

NFS Most Wanted has stability issues when enabling RCB or RSX Tiled memory before going ingame If I enable RCB with WCB+RSX Tiled memory, the game crashes with this error: WCB+RCB+RSX Tiled memory:

However if I try disabling RCB or RSX Tiled memory, the game works fine and enters ingame successfully. WCB+RSX Tiled memory:

WCB+RCB+RSX Tiled memory: RPCS3.log.gz

This should be a separate ticket.

[Ordinary205]

NFS Most Wanted has stability issues when enabling RCB or RSX Tiled memory before going ingame If I enable RCB with WCB+RSX Tiled memory, the game crashes with this error: WCB+RCB+RSX Tiled memory: However if I try disabling RCB or RSX Tiled memory, the game works fine and enters ingame successfully. WCB+RSX Tiled memory: WCB+RCB+RSX Tiled memory: RPCS3.log.gz

This should be a separate ticket.

Well I thought it would be a good idea to report this issue on this ticket, since its an RSX tiled memory bug, but I'll make a report anyways.

[kd-11]

I create the tickets for specific work items but these are usually theoretical (i.e no logs). This error is unexpected hence the assert rather than just broken graphics.

[kd-11]

With https://github.com/RPCS3/rpcs3/pull/14985, frostbite now renders semi-correctly. The only issue left to resolve is the texture tiling (repeating) which is a known blit-engine issue that I was never able to observe directly.

[kd-11]

https://github.com/RPCS3/rpcs3/pull/14985 also fixes split/second issue with missing effects. That was being tracked by https://github.com/RPCS3/rpcs3/issues/14984

[legend800]

Gfx broken on Split Second with this PR (100%):

Settings: Strict(fix red lines), WCB + RCB + RSX tiled memory(skybox smearing and env lighting), 100% res(pixelation)

Split Second [NPUB30450].log.gz

[kd-11]

That was always inconsistent for me even before the PR. Likely some timing thing. In my case I use all the buffer options and tiled mem option. It could be related to the mirrors effect bug but that's something else.

[legend800]

R/W depth buffers aren't needed. Results are 100% consistent, so I don't think there's a race condition here. Gfx broken on PR (https://github.com/RPCS3/rpcs3/pull/14985) and fine on the latest Master build (aside from what's noted here https://github.com/RPCS3/rpcs3/issues/14984):

Master:

Split Second [NPUB30450].log.gz

[legend800]

@kd-11 Did you see this comment here: https://github.com/RPCS3/rpcs3/issues/14984#issuecomment-1873414256?

Game was not improved and that PR only regressed it. This is not accurate:

[Asinin3]

Why tag someone three times about the same thing.

[legend800]

Because I'm trying to get attention on it. I pinged him twice and it was not acknowledged and I've seen no follow-up. It's just broken now.

[Asinin3]

@legend800 Once is enough, don't spam.

[kd-11]

Vertical repeats and flickering at the bottom of the screen (star wars) are caused by tile encoding into partial 2D regions. This is not allowed because the spatial distribution is not coherent. A linear 2D region scatters the pixels all around in X and Y with the exception that Y regions seem to behave. Either way, some changes are needed to ensure the whole tile is available to the encoder:

• [x] Encoder block should overwrite the mapping and basically just render to tile.
• [x] DMA sections created from tiles must preload the entire tile. Memory operations make no sense otherwise.

With halfplemented variants of the above the mirror/repeat bug disappears from NFS:Rivals and Split/Second.

[kd-11]

I've implemented the requirements above in https://github.com/RPCS3/rpcs3/pull/15160 However, there is now a strange bug where partial writes cause flicking in the top and bottom parts of the frame. Loading the entire tile from offset 0 hides the bug so I don't know what is actually causing it.