RPCS3 / rpcs3

PS3 emulator/debugger
https://rpcs3.net/
GNU General Public License v2.0
14.5k stars 1.85k forks source link

Qt/Logs: Fixing spaces, optimize string to html conversion #15549

Closed elad335 closed 2 weeks ago

elad335 commented 2 weeks ago

Every time that more than one space was repeated in a log message, the Qt log frame would display it as one. Replace it with non-breaking space. Also: Remove two redundant copies of the QString on HTML escaping when not needed. The first was being done by QString::toHtmlEscaped(), and the second was done as an unfortunate result of QString::replace() return lvalue reference, which creates a copy upon rvalue conversion. (this matters mostly for huge log messages)

Misc commits:

Megamouse commented 2 weeks ago

Please give people time to review your amalgamation of random changes in the future.