RPCS3 / rpcs3

PS3 emulator/debugger
https://rpcs3.net/
GNU General Public License v2.0
14.5k stars 1.85k forks source link

merge qt_camera_error_handler into qt_camera_handler #15557

Closed oltolm closed 1 week ago

oltolm commented 1 week ago

This PR merges qt_camera_error_handler into qt_camera_handler. When I tried to understand the camera code it seemed overly complicated to me, so I decided to simplify it.

Megamouse commented 1 week ago

The camera handler is not supposed to be a QObject. That's why

Megamouse commented 1 week ago

Just to explain: You're missing the Q_OBJECT macro that's needed for signals and slots. When I implemented this feature, it didn't work with the rest of the software (or didn't even compile. I don't remember exactly).

oltolm commented 1 week ago

Yes, I forgot Q_OBJECT. I added it and fixed the compilation error. Multiple Inheritance Requires QObject to Be First.

oltolm commented 1 week ago

I also merged qt_music_error_handler into qt_music_handler.