RPCS3 / rpcs3

PlayStation 3 emulator and debugger
https://rpcs3.net/
GNU General Public License v2.0
15.33k stars 1.91k forks source link

Nullpointer in sceNpMatching2SetRoomDataExternal #15689

Closed halvors closed 4 months ago

halvors commented 4 months ago

Quick summary

When hosting a match (but requires custom servers) in 007: Legends or GoldenEye 007: Reloaded the game crashes due to a nullpointer in sceNpMatching2SetRoomDataExternal.

Details

The roomBinAttrExternalNum says 1 element, yet roomBinAttrExternal: *0x0 is a nullpointer, causing crash here? https://github.com/RPCS3/rpcs3/blob/master/rpcs3/Emu/NP/np_structs_extra.cpp#L117

·W 0:01:24.327386 {PPU[0x1000011] Thread (Online Thread) [HLE:0x00df584c, LR:0x005bc478]} sceNp2: roomBinAttrExternal: *0x0
·W 0:01:24.327387 {PPU[0x1000011] Thread (Online Thread) [HLE:0x00df584c, LR:0x005bc478]} sceNp2: roomBinAttrExternalNum: 1
·F 0:01:24.327414 {PPU[0x1000011] Thread (Online Thread) [HLE:0x00df584c, LR:0x005bc478]} PPU: Function aborted: sceNpMatching2SetRoomDataExternal

Attach a log file

RPCS3_007_legends_create_match_crash.log RPCS3_golden_eye_007_reloaded_create_match_crash.log

Attach capture files for visual issues

No response

System configuration

No response

Other details

Custom servers are required to get into Multiplayer menues, but the games are using NP matching2 for matchmaking

halvors commented 4 months ago

I can confirm that PR #15690 solves the issue for 007: Legends and GoldenEye 007: Reloaded :-)