search

RPCS3 / rpcs3

PlayStation 3 emulator and debugger
https://rpcs3.net/
GNU General Public License v2.0
15.54k stars 1.92k forks source link

Line artifacting when upscalling Guitar Hero: Warriors of Rock #16271

Open kernaltrap8 opened 3 weeks ago

kernaltrap8 commented 3 weeks ago

Quick summary

When upscalling, GH:WoR has some minor, but noticeable artifacting on some parts of the viewport. image If I upscale to 4K, this artifacting goes away. It is not present when running at the native game resolution of 720p. Look at the drumkit in this image. If you look at the right kick drum, there are some lines. These lines are the artifacting I am talking about. It is also visible too the right of the kit.

Details

No response

Attach a log file

RPCS3.log.gz

Attach capture files for visual issues

BLUS30487_20241031185439_capture.rrc.gz

System configuration

CPU: AMD Ryzen 7 5800x GPU: AMD Radeon RX570 OS: Gentoo Linux (6.11.4-gentoo-dist)

Other details

No response

Darkhost1999 commented 3 weeks ago

I haven't seen issues with upscaling accepted before on github. 150% values or non-integer values commonly have some very minor issues in games. While values of 200% and 300% are best. If you scale above your monitor/display resolution you only end up benefiting from SSAA. Yet if everything works at 720p resolution I have seen this as "not an emulation issue" for now. But I am sure someone official will re-evaluate.

kernaltrap8 commented 3 weeks ago

I haven't seen issues with upscaling accepted before on github. 150% values or non-integer values commonly have some very minor issues in games. While values of 200% and 300% are best. If you scale above your monitor/display resolution you only end up benefiting from SSAA. Yet if everything works at 720p resolution I have seen this as "not an emulation issue" for now. But I am sure someone official will re-evaluate.

I see it as a emulation issue if the artifacting only happens at certain resolutions.

RainbowCookie32 commented 3 weeks ago

Unless it's a regression, issues from upscaling are not valid. The games were never meant to run beyond what they ran on the PS3 and may not play along. Upscaling is an enhancement that may or may not be compatible with the games you want to play

kernaltrap8 commented 3 weeks ago

Unless it's a regression, issues from upscaling are not valid. The games were never meant to run beyond what they ran on the PS3 and may not play along. Upscaling is an enhancement that may or may not be compatible with the games you want to play

I don't think you understand. At 720p, the artifacting isn't present. At any resolution before 4K that is above 720, the artifacting appears. It is not present 4K or above.

alexconsole04 commented 3 weeks ago

The artifacts don't appear on native resolution because it's native resolution. As already said, upscaling the resolution will cause issues on some games since they were never supposed to run on higher resolutions, which as a result, will cause visual artifacts. Please slowly reread your statement and you'll see why it makes no sense for this GitHub issue to be a thing.

Virtua64 commented 2 weeks ago

The artifacts don't appear on native resolution because it's native resolution.

But they dont appear at 4k either. Anyway, try changing the Resolution Scale Threshold to 128x128 or 512 X 512 or even 1x1 to see if it resolves the issue.