RPCS3 / rpcs3

PlayStation 3 emulator and debugger
https://rpcs3.net/
GNU General Public License v2.0
15.36k stars 1.91k forks source link

Vulkan: ZCull Emulation #3514

Closed Cornflak closed 6 years ago

Cornflak commented 7 years ago

When using Vulkan, the sun is always showing through buildings and casts a lens flare. OpenGL solves it, but the frame rate suffers a bit more. capture

ScorchEmber256 commented 7 years ago

Sounds like an RSX issue because some games (The Jak and Daxter Collection) rely on depth culling, maybe @kd-11 could look into that :| capture 2nd

Log spams a different indirect problem with animated textures: E {rsx::thread} RSX: Blit request denied because the destination region does not fit!

kd-11 commented 7 years ago

Zcull emulation on vulkan is still not done.

geo98 commented 7 years ago

When more or less it's planned to be done? (a rough idea)

frymezim commented 7 years ago

@geo98 Put a $1000 bountysource for that he'll fix it for you.

geo98 commented 7 years ago

@frymezim What do you mean? (I'm not a native english speaker)

Lmmb74 commented 7 years ago

@geo98 BountySource is a service where you can publish a reward for fixing issues in your projects, or earn money fixing published issues

geo98 commented 7 years ago

@Lmmb74 It seems very interesting, but I wanted to know what @frymezim meant.

dbz400 commented 6 years ago

Just seen the vulkan zcull emulation somewhere and looks like it fixes the lens flare .

https://github.com/popbob/rpcs3/commits/vk-zcull

This is the appveyor build - https://ci.appveyor.com/project/raven02/rpcs3-ppr74/build/0.0.3-273/artifacts

AniLeo commented 6 years ago

Closing as it has been implemented by #3827