RPCS3 / rpcs3

PlayStation 3 emulator and debugger
https://rpcs3.net/
GNU General Public License v2.0
15.39k stars 1.91k forks source link

Regression: Yakuza 3 Demo (#3772) #4128

Closed Xcedf closed 6 years ago

Xcedf commented 6 years ago

commit 51891039 makes yakuza 3 suffer from unknown color artifact also i found that reverting line if (pitchs[index] < required_color_pitch) back to if (pitchs[index] < 64) fixes this for both backends that how it looks on master 1 and how it should look after fix and looked before it was broken 5 please take a look

Xcedf commented 6 years ago

Little update: It seems also affects Gran Turismo HD Concept broken revision 22 the revision before the broken one 13

kd-11 commented 6 years ago

Just FYI, that fix actually just disables the whole block since pitch will never be less than 64. Pitch 64 seems to be allowed for some corner cases but I'm not enabling it as viable until I find the registers affecting its validity.

Xcedf commented 6 years ago

I see, anyway i reported that's all i can do.

kd-11 commented 6 years ago

https://github.com/RPCS3/rpcs3/pull/4136 has a potential fix for this. Retest with that build.

Xcedf commented 6 years ago

Yes fixed, thanks alot

AniLeo commented 6 years ago

Fixed by #4136