[BLJS10053] Tales of Vesperia - Remaining rendering issues

GeniusMage commented 6 years ago

Continuation of #2707.

Issues to fix:

[x] Black characters
[x] Blue veil
[x] Shadows: Not every character gets their shadow, but it's no longer a square.
[x] Scrambled text
[x] Lighting issue
[x] Frame persistence issue
[x] Half-screen issue
[x] Possible Alpha glitch (?) on the fountain in Zaphias' lower quarter
[ ] Wrong colors on characters textures (unrelated to SRM, the issue appears even without it)
[ ] Lack of bloom in certain cutscenes
[x] ~~Requires Strict Rendering Mode~~

Screenshots

![bandicam 2018-03-29 10-19-59-500](https://user-images.githubusercontent.com/27543170/38077968-1d118698-333b-11e8-9a01-50314e57e5f4.png) ![bandicam 2018-03-29 10-21-49-058](https://user-images.githubusercontent.com/27543170/38077983-252e7ad4-333b-11e8-8dc3-42eecec96a47.png)

Log

kd-11 commented 6 years ago

Requires strict mode is not a bug. The solution would be to make strict mode permanent then everyone is forced to use it all the time.

kd-11 commented 6 years ago

A patch.yml entry could force the game to not do the risky stuff (really only one thing) but thats for interested community members to do. Requires a hex editor and replacing 2560 with 1280 where it creates that bugged double-width surface declaration.

Illynir commented 6 years ago

I tested a little, the shadows work randomly, sometimes some characters have, sometimes not. The portrait during the fights is green, there is a problem with the alpha, we see a rectangle around the portrait and the fountain at the beginning. The chain on the dog at the beginning also makes a strange movement

unknown unknown2

GeniusMage commented 6 years ago

The chain of the dog moving is not a bug, it happens on real hardware too. You're using kd's master, something in his build causes the green portrait (EDIT: ~~now on PR 4382~~ fixed)

Illynir commented 6 years ago

Ok for the green portrait, however just checked on a real PS3 and the dog chain on the intro is quite normal unlike RPCS3...

There also remains the alpha problem of the fountain and the portrait.

wakka1 commented 6 years ago

Tested after the latest animation speedup PR #4661 Current issues i noticed :

1- fountain glitch untitled4

2- half-screen issue during menus and some cut-scenes half-width

3- Character outline are jagged (aliasing?) 4- wrong colors. Noticeable on pink hair and the guard on the left 5- i may be wrong on this one, but i think a faint bloom is missing on the emulator (faces + clouds) rpcs3 real ps3

edit : forgot to mention the chain on the dog glitch in the beginning is also still there.

windows 10 i7 7700 16gb ram gtx 1060

GeniusMage commented 6 years ago

Those are all listed (except the bloom, I'll check and add it if necessary) Character edges are obviously jagged, since it's 720p and FXAA is not applied by the emulator. The dog chain glitch is not a bug, it happens on real hardware (and yes, I have retested, it does happen, though not consistently).

pauls-gh commented 6 years ago

I debugged the half-screen issue. It appears to be an rpcs3 issue with surface width/height changes.

I should have a fix soon (1-2 days).

Illynir commented 6 years ago

Debuggued this should result in fixing a lot of other games with a similar problem in addition.

GeniusMage commented 6 years ago

Alright, I added the fountain glitch and the bloom issue to the first post. I think the bloom issue is actually there because light isn't being quite properly applied to characters. I also believe the fountain glitch could be related to the characters texture bug.

wakka1 commented 6 years ago

Shadows bug. https://imgur.com/OAXzgAs

pauls-gh commented 6 years ago

Quick update on half screen issue. Initial idea for a fix didn't pan out, but I haven't given up yet.

Zangetsu38 commented 6 years ago

for shadow bug, i have already report this to kd, i have see very lot game with same bug

pauls-gh commented 6 years ago

I think I've figured out the half-screen issue. PR coming soon.

half_screen_fix

asbel123 commented 6 years ago

Best worst glitch before U go to ride dragon to top of Tower of gears U get 1fps Cutscene worst bloom I am rember real PS3 has that slow down too.

Don't let people on YouTube this game playable.

https://youtu.be/9gThDuVT0os go to 22.26 on that YouTube video on the link this the Cutscene U get 1 fps

pauls-gh commented 6 years ago

https://github.com/RPCS3/rpcs3/pull/4692

This PR looks like it fixes both

half screen
fountain alpha issue (nice side effect of the half screen fix).

fifazalata commented 6 years ago

@pauls-gh is it a hacky fix that will need more work or a proper fix? & btw thanks for ur dedicated work towards a smooth ToV experience ;)

pauls-gh commented 6 years ago

It's hacky and it will need more work and a proper fix. kd-11 is taking a look a it.

pauls-gh commented 6 years ago

kd-11 has a proper fix for the half-screen issue. https://github.com/RPCS3/rpcs3/pull/4698

It fixes

half-screen issue in Vesperia/Graces
fountain issue in Vesperia
non-aligned cell-shading in Graces

Known issues with kd-11's change.

cell-shading is very pronounced in Vesperia.
blue filtering (of distance objects) in town is missing.

pauls-gh commented 6 years ago

I spent some time looking at the character texture color issue. This is easily seen in the first cut-scene. The characters faces look darker (more orange) than the PS3 version.

I used renderdoc to capture the scene on RPC3. I then captured the same scene with Xenia (xbox360 emulator). Xenia displays the correct skin color in the scene.

I found the same face texture on both rpcs3 and Xenia. It appears that the skin color is simply darker in RPC3 than Xenia. The red/yellow components looks exactly the same as Xenia, but the blue component is darker for some reason.

The face texture is BC3 (compressed, 5:6:5 alpha 8 bit). Interestingly, the ear texture (a separate texture) is the correct color, but it is BC1 (compressed, 5:6:5 alpha 1 bit). I'm not sure if this matters as I assume both textures are read directly from the TOV ISO files. I don't think there is any conversion done by rpcs3.

Xenia (xbox 360 emulator) - correct face color

renderdoc_facecolor_xenia

rpcs3 - incorrect face color

renderdoc_facecolor_rpcs3

pauls-gh commented 6 years ago

If you zoom in around the eye lid, you can see there are splotches of the correct color. It's almost like the artist gave up, or a failed flood fill. Strange.

asbel123 commented 6 years ago

Can do higher deatil like texture mod like final fantasy X hd PC version or use Photoshop that's what Xenoblade Wii used to fix character eyes.

Ristellise commented 6 years ago

@pauls-gh If you look REALLY closely at the Xenia one, there is a slight color difference in xenia's. the eyelids and the rest of the face. I guess its once of those RPCS3 color issues.

pauls-gh commented 6 years ago

@Ristelle - you're right. The "Night Light" on Win10 was masking the difference for me.

Ristellise commented 6 years ago

On entering Capua Nor for the first time, Game Freezes with Trap Exception:
RPCS3.log.gz

asbel123 commented 6 years ago

U get it in before U go to Tower of gears U framerate will drop to 1where lots of solder there is a lots a trap error until they fix it or wait E3 tales of vesperia remastered version come out

GeniusMage commented 6 years ago

Trap errors happen in specific areas when compiling some shaders. Usually, you can reload the game after a crash and go past a spot. Knowing where those spots are can help, as you'd know where to absolutely save, though I recommend always saving before leaving or entering any new area (town or dungeon), if possible.

elad335 commented 6 years ago

Still an issue?

GeniusMage commented 6 years ago

Just tested on one of the latest builds, the texture bug is still there, and the bloom is apparently also lacking (looks like wakka1's screenshot from May 27th, point 5). Though to be fair, the same texture bug appeared on official WIP screenshots from the remaster (textures that weren't revamped yet), it could be an issue with the textures themselves or how a PC driver treats them.

Ristellise commented 5 years ago

Well I really shouldn't be bumping a dead post but as of Build 52ac0a901acac98d05ed9c989069b9ea107082b4, the Game has a constant spam of RSX TODO: Resource used before memory initialization

GeniusMage commented 5 years ago

It's not closed, so feel free to post. I've found this too: Deidon The blue effect is out of place. No SRM There's also been some changes without SRM, though I'm not sure how new this is.

Parthorisian commented 5 years ago

Not problem anymore, Sega just ported this game to Windows yet :)

AniLeo commented 5 years ago

doesn't matter, the game port doesn't magically make it fixed on the emulator

Ristellise commented 5 years ago

Also, it aint Sega but Bandai Namco.

kd-11 commented 5 years ago

Needs an update or close.

Illynir commented 5 years ago

The last two problems are always relevant today

GeniusMage commented 5 years ago

Couldn't do extensive testing since my PC seems to hate the emulator currently (Vulkan doesn't work on my end, and OGL is pretty slow, I blame my iGPU). SRM is no longer needed, and from what I've seen the last two issues are still there. I'll try to test more once I've changed my CPU sometime next month.

GeniusMage commented 5 years ago

Re-tested on latest download version, and managed to get it to work on Vulkan (turns out it was Turing's fault). The last two issues are still there. I'm still unsure if that texture issue can be fixed.