RPCS3 / rpcs3

PlayStation 3 emulator and debugger
https://rpcs3.net/
GNU General Public License v2.0
15.43k stars 1.92k forks source link

SPU LLVM graphical issues #4937

Closed Xcedf closed 6 years ago

Xcedf commented 6 years ago

Spu llvm has a lot graphical issues, i've made investigation on some of them and discovered that long time ago SPU ASMJit also suffered from these issues, but they were fixed by https://github.com/RPCS3/rpcs3/pull/2683. I reverted this PR on current build to made some comparisson with llvm and the issues look the same: Red Dead Redemption ASMJit +PR Reverted 4 SPU LLVM 5

Midnight Club: Los Angeles ASMJit +PR Reverted 12 SPU LLVM 6

Metal Gear Rising ASMJit +PR Reverted 13 SPU LLVM 22

Ninja Gaiden Sigma 2 ASMJit +PR Reverted 29 SPU LLVM 30

God of War III Demo ASMJit +PR Reverted 32 SPU LLVM 31

The PR itself above the year old, the reason ASMJit never had these issues, cause none of these games, except Metal Gear Rising showed ingame graphics back those days, i think improving these instructions accuracy in llvm will make games more playable.

hcorion commented 6 years ago

These are all fixed in #4920

Xcedf commented 6 years ago

Fixed now