RPCS3 / rpcs3

PS3 emulator/debugger
https://rpcs3.net/
GNU General Public License v2.0
15.15k stars 1.89k forks source link

Regressions from #5675 #5708

Closed kd-11 closed 5 years ago

kd-11 commented 5 years ago

A regression tracker for any remaining bugs introduced by https://github.com/RPCS3/rpcs3/pull/5675.

EDIT: When reporting a regression, check if its fixed by enabling WCB and/or forcing CPU blit from the debug option.

TODO:

MSuih commented 5 years ago

Yakuza 4 Ingame is now almost completely black now, only showing some lights in distance. Also there seems to be a still image that constantly flickers over the right side of the screen. Affects both opengl and vulkan. image

The game also spams RSX: Blit request consists of an empty region descriptor! to log.

Indoor segments look a bit better, sometimes showing half or even full frame of correct graphics through the flicker. image

Enabling WCB or CPU blit separately don't change anything. Enabling them both on OpenGL prints the following error to log and crashes the whole emulator: RSX: g_access_violation_handler(0xc2650004, 0): Assertion failed: src != nullptr (in file ...\rpcs3\emu\rsx\common\texture_cache_utils.h:1403) On vulkan it fixes the flicker, but graphics are still mostly black. image

In an earlier version of the PR Yakuza 4 worked fine, but I wasn't checking it often enough to know which change caused it to regress.

legend800 commented 5 years ago

Do you not want issues that are fine with WCB + Blit?

Regression List:

Burnout Crash: (with or without WCB + Blit) No longer playable - mad flickering of objects in levels following by a crash within a min or so (2/2 repro). GFX/stability perfect on Master. Happens with/w/o WCB+Blit.

S {RSX Decompiler Thread} RSX: New program compiled successfully x6 F {RSX [0x025d690]} RSX: class std::runtime_error thrown: Verification failed: (in file c:\projects\rpcs3\rpcs3\emu\rsx\common\texture_cache.h:2101)

Backbreaker Vengeance: Broken "Touchdown" text (only with WCB+Blit off): bb2

Broken field logo: (with or without WCB + Blit) bb

Motorstorm Apoc. - (Needs wcb to render ingame gfx, blit makes everything black) Does a weird thing now, where it shows a discolored edge that moves itself to the edge of screen and makes the black border bigger than normal. Strange.

Master: moto1

PR: moto2

Then transitions to this.... moto3

jenci8888 commented 5 years ago

Elad's PR merged from master branch, I've got excited to test GT6 game

Game: GT6 Settings: All tried, no changes effect. Vulkan: F {RSX [0x119dc0c]} RSX: class std::runtime_error thrown: Assertion Failed! Vulkan API call failed with unrecoverable error: Device lost (Driver crashed with unspecified error or stopped responding and recovered) (VK_ERROR_DEVICE_LOST) (in file c:\projects\rpcs3\rpcs3\emu\rsx\vk\vkhelpers.h:1278) OGL: F {RSX [0x1918d68]} RSX: class std::runtime_error thrown: Assertion failed: src != nullptr (in file c:\projects\rpcs3\rpcs3\emu\rsx\common\texture_cache_utils.h:1403) log: RPCS3.log.gz

Game: GT5 Settings: Default Vulkan: F {RSX [0x0013080]} RSX: class std::runtime_error thrown: Assertion Failed! Vulkan API call failed with unrecoverable error: Device lost (Driver crashed with unspecified error or stopped responding and recovered) (VK_ERROR_DEVICE_LOST) (in file c:\projects\rpcs3\rpcs3\emu\rsx\vk\vkhelpers.h:1278) (night tracks including wet/time changeable)

F {PPU[0x1000010] Thread (ksF3) [0x01cb5ae4]} RSX: g_access_violation_handler(0xc68c3000, 1): Unexpected vkFormat 0x0

RPCS3.gz

Kravickas commented 5 years ago

Far Cry 3

Parts of the menu are corrupted obrazek

I have RSX capture - but in few tries it didnt show up there and OGL is stuck before any splash screen and in rsx capture it is fine as well. RPCS3.log.gz

No longer spam of U {RSX [0x00836fc]} RSX TODO: Resource used before memory initialization but instead it spam few time E 0:00:38.630530 {RSX [0x00721ac]} RSX: Unsupported depth conversion (0x9C)

WCB / CPU blit / Off async doesnt do a thing

uaqlover commented 5 years ago

issue with Ben 10™ Galactic Racing [BLUS30822]

12333

RPCS3_ Fatal Error 10_03_2019 3_24_55 PM

log file RPCS3 10.log.gz

uaqlover commented 5 years ago

rpcs3-v0.0.6-7857-1875dc3f_win64

NASCAR® Unleashed [BLUS30806]

after playing like 5 minute it freeze

video

https://drive.google.com/file/d/1it4278clFvGgjMzk3Cx_yPaSb22fXxFG/view?usp=sharing

FPS_ 321 76 _ OpenGL _ 0 0 6-7857 _ NASCAR® Unleashed  BLUS30806  10_03_2019 3_37_10 PM

F {RSX [0x0061b9c]} RSX: class std::runtime_error thrown: Assertion failed: src != nullptr (in file c:\projects\rpcs3\rpcs3\emu\rsx\common\texture_cache_utils.h:1403)

Rampage World Tour [NPUB30003]

is issue is back on master

F {PPU[0x1000006] Thread (Thread 1) [0x0013a3cc]} MEM: Access violation reading location 0x0 W {cellAudio Thread} cellAudio: Audio backend stopped unexpectedly, likely due to a buffer underrun

but when ever i try rpcs3-v0.0.6-49120261_win64 is working

FPS_ 59 96 _ Vulkan _ 0 0 6-49120261-fbo_fixes _ Rampage World Tour  NPUB30003  10_03_2019 3_43_51 PM

BreakPoints commented 5 years ago

Emulation freezes with:

F {RSX [0x012afe8]} RSX: class std::runtime_error thrown: Verification failed (e=0x7f): (in file c:\projects\rpcs3\rpcs3\emu\rsx\gl\gltexturecache.h:200)

when launching Jak 2 or 3 from Jak and Daxter Collection under both Vulkan and OpenGL

uaqlover commented 5 years ago

Monster Jam: Path of Destruction [BLUS30561]

(cpu Blit off):

FPS_ 29 58 _ Vulkan _ 0 0 6-7857 _ Monster Jam_ Path of Destruction  BLUS30561  10_03_2019 7_27_59 PM

(cpu Blit on):

FPS_ 17 31 _ Vulkan _ 0 0 6-7857 _ Monster Jam_ Path of Destruction  BLUS30561  10_03_2019 7_29_56 PM

alexloxldlol commented 5 years ago

image

Shoegzer commented 5 years ago

Bioshock also seems to be affected, as noted in #5609:

pic

stride21 commented 5 years ago

In Ratchet and Clank Future: A Crank in Time with OpenGL, the top left of the screen only looks correct for ratchets fur and the crosshair when aiming in certain directions for this master while the previous master looks correct no matter what direction your aiming. Previous Master OpenGL: ratchet master Master OpenGL: Capture

5675 fixed the auger sight for Vulkan but OpenGL still has issues when using the sight. The very top left corner of the screen can show enemies and the environment but the rest of the sight is a still image.

Vulkan: vulkan resis OpenGL(most of the left side of the screen is a still image): rpcs3 resis

SkyEua commented 5 years ago

In this new version (rpcs3-v0.0.6-7867-980c3d6f_win64).

001

The menu still continues with the same problem; but in the game. The game came back to work normally, only in these parts of "balance" happens an FPS fall

002

What did not happen in this version of the RPCS3 emulator v0.0.6-7840-a43e7c17, even running in 5K, was perfect

Note: from the RPCS3 version v0.0.6-7840-a43e7c17 - FOR - RPCS3 v0.0.6-7857-1875dc3f the game gets injurious 0,73FPS

kd-11 commented 5 years ago

Need some general feedback with this build https://ci.appveyor.com/project/kd-11/rpcs3/builds/23040747/artifacts. Note: Please check both OpenGL and Vulkan and note differences if any. Flickering with vulkan in some games is expected due to uneven performance desynchronizing Cell threads. This is being worked on. If it works fine on OpenGL and is mysteriously flickering with vulkan that is likely the cause.

BreakPoints commented 5 years ago

The regression that I reported has been fixed in the new build. Not noticing any differences with master in Jak and Daxter's case.

Emulation freezes with:

F {RSX [0x012afe8]} RSX: class std::runtime_error thrown: Verification failed (e=0x7f): (in file c:\projects\rpcs3\rpcs3\emu\rsx\gl\gltexturecache.h:200)

when launching Jak 2 or 3 from Jak and Daxter Collection under both Vulkan and OpenGL

uaqlover commented 5 years ago

working with this build

Rampage World Tour NPUB30003

FPS_ 63 94 _ Vulkan _ 0 0 6-7862 _ Rampage World Tour  NPUB30003  13_03_2019 2_37_55 PM

Monster Jam: Path of Destruction [BLUS30561] is same

FPS_ 29 77 _ Vulkan _ 0 0 6-7862 _ Monster Jam_ Path of Destruction  BLUS30561  13_03_2019 2_37_22 PM

stride21 commented 5 years ago

In Resistance 3 the size of the screen portion that shows graphics when using the auger sight can expand and contract in size or completely disappear. When it contracts it can leave a still image that is the same size as the previous portion and it doesn't go away when it happens but with the PR it no longer shows still images when using the auger. resistance 3 no still

Ratchet and Clank Future: A Crank in Time is still the same with the recent PR.

SkyEua commented 5 years ago

Need some general feedback with this build https://ci.appveyor.com/project/kd-11/rpcs3/builds/23040747/artifacts. Note: Please check both OpenGL and Vulkan and note differences if any. Flickering with vulkan in some games is expected due to uneven performance desynchronizing Cell threads. This is being worked on. If it works fine on OpenGL and is mysteriously flickering with vulkan that is likely the cause.

RPCS3 v0.0.6-7862-154c8a2e With vulkan, the game presents itself correctly, all the time in 30FPS even in 4k. Only the opening screen, below 9FPS this time. But occasionally I get the error: F {RSX [0x014dea8]} RSX: class std::runtime_error thrown: Assertion Failed! Vulkan API call failed with unrecoverable error: Device lost (Driver crashed with unspecified error or stopped responding and recovered) (VK_ERROR_DEVICE_LOST) (in file c:\projects\rpcs3\rpcs3\emu\rsx\vk\vkhelpers.h:1278)

image

Already in OpenGL, It behaves the same way, low fps only in opening; running 30FPS at all times. But when it comes to the "balance" part the FPS drops.

image

I would have sent the log file, but it gets really big 2GB ????

legend800 commented 5 years ago

Results from new build:

No change: (VK/OpenGL same) Backbreaker Vengeance broken TD text/logo

Fixed: Burnout flicker/crashes

Worse: Motorstorm Apocalypse border issue:

VK: 2019-03-13 19_56_51-FPS_ 12 76 _ Vulkan _ 0 0 6-7862 _ MOTORSTORM™_ APOCALYPSE Digital Edition  NPUA

Much worse on OpenGL: 2019-03-13 20_11_09-FPS_ 3 69 _ OpenGL _ 0 0 6-7862 _ MOTORSTORM™_ APOCALYPSE Digital Edition  NPUA8

jenci8888 commented 5 years ago

~~GT5 and GT6 fails at intro, when SPU race condition breaks, both same error in log. (I've tried change all settings and no effect.) However, Master doesn't have a problem, either. (Still remains RSX verification error) F {SPU[0x2000001] Thread (PDICellSpursKernel1) [0x08074]} MEM: Access violation writing location 0x611e0000 Log: RPCS3.zip~~

Forget it, I created new folder, it seems like stuck infinite loading in GT6 and GT5 ingame right now.

kd-11 commented 5 years ago

https://ci.appveyor.com/project/kd-11/rpcs3/builds/23070933 Should fix unstable vulkan image (flickering)

kd-11 commented 5 years ago

@jenci8888 I can't look into it if it dies with SPU crash; I certainly do not touch anything on SPU with this change.

elad335 commented 5 years ago

This looks like a page fault miss.

MarioSonic2987 commented 5 years ago

With Vulkan, MCLA now shows pink flickering reflections. Enabling Force CPU blit doesn't fix it. SRM and WCB (needed to fix broken car) are enabled.

Before #5675: image

#5675 and after: image

I've tested with the build provided by kd-11 and it still has this bug.

kd-11 commented 5 years ago

You forgot to clarify what OpenGL looks like or if strict mode does anything.

Emulator-Team-2 commented 5 years ago

@jenci8888 The fbo_fixes branch is not rebased on the latest master, so there is no fix for gt 5/6 in this branch.

MSuih commented 5 years ago

The only change for Yakuza 4 is that the OpenGL CPU blit + WCB crash has changed to RSX: class std::runtime_error thrown: Verification failed: (in file c:\projects\rpcs3\rpcs3\emu\rsx\gl\glhelpers.h:303) It also no longer crashes the whole emulator.

MarioSonic2987 commented 5 years ago
MCLA OpenGL **Before #5675**: With WCB (Different lighting is due to the game loads a different landspace in title screen.): ![image](https://user-images.githubusercontent.com/20027681/54368566-b185d700-4674-11e9-9d8f-574892924d1a.png) Without WCB: ![image](https://user-images.githubusercontent.com/20027681/54369114-a5e6e000-4675-11e9-975b-6c1debc82030.png) **#5675 and after**: Without WCB, has black flickering reflections. ![image](https://user-images.githubusercontent.com/20027681/54368853-2eb14c00-4675-11e9-9c58-48780f3dd480.png) With WCB, throws this in console and crashes the emulator: ``` ·F 0:01:26.276390 {RSX [0x001e01c]} RSX: class std::runtime_error thrown: Assertion failed: src != nullptr (in file c:\projects\rpcs3\rpcs3\emu\rsx\common\texture_cache_utils.h:1403) ``` With fbo_fixes new build, it still has black reflections without WCB. CPU blit doesn't fix it. With WCB, throws this in console and crashes the emulator: ``` F {RSX [0x0031afc]} RSX: class std::runtime_error thrown: Verification failed: (in file c:\projects\rpcs3\rpcs3\emu\rsx\gl\glhelpers.h:303) ```
SkyEua commented 5 years ago

https://ci.appveyor.com/project/kd-11/rpcs3/builds/23070933 Should fix unstable vulkan image (flickering)

In the "balance" part this is working normally, even in the part of the introduction. Only in this part that remains the same.

image

kd-11 commented 5 years ago

@MSuih So vulkan is still broken? I'll look into the OGL issue. @SkyEua We had this regression before; I remember it was easy to fix - will look into it. Fortunately the most dangerous bug (flickering, which means race conditions) is gone now so the rest should be manageable.

Emulator-Team-2 commented 5 years ago

After #5675 Iron Man-Demo now hangs up on the loading screen before entering the game.

Master: Last error in the log: RSX: Depth<->RGBA blit on a framebuffer requested but not supported Log: RPCS3.zip

With WCB + CPU blit crashes with fatal error: [Vulkan] F {RSX [0x0007860} RSX: class std::runtime_error thrown: Verification failed (e=0x7f): (in file c:\projects\rpcs3\rpcs3\emu\rsx\vk\vkgsrender.cpp:3318)

[OpenGL] F {RSX [0x00072c0]} RSX: class std::runtime_error thrown: Verification failed (e=0x7f): (in file c:\projects\rpcs3\rpcs3\emu\rsx\gl\glgsrender.cpp:1649) Log: RPCS3-Log-Master.zip


With Latest build from [fbo_fixes] branch:

Still hangs on the loading screen, but show more errors: RSX: Depth<->RGBA blit on a framebuffer requested but not supported RSX: Area merge failed! addr=0xc1ab8000, w=1024, h=4096, gcm_format=0x85[sz=0] RSX: Btw, you're about to lose a blit surface at 0xc1eb8000 Log: RPCS3.zip

With WCB + CPU blit: [OpenGL]: RSX: g_access_violation_handler(0xc0fe0000, 0): Verification failed: (in file c:\projects\rpcs3\rpcs3\emu\rsx\gl\glhelpers.h:303)

[Vulkan]: F {RSX [0x000750c]} RSX: class std::runtime_error thrown: Verification failed (e=0x7f): (in file c:\projects\rpcs3\rpcs3\emu\rsx\vk\vkgsrender.cpp:3287) Log: RPCS3-Log.zip

MSuih commented 5 years ago

@kd-11 Yes, Vulkan is still broken.

MsDarkLow commented 5 years ago

Rogue Legacy Before #5675, Vulkan and OpenGL render correctly without the need of WCB. GOOD RPCS3 Before.log.gz

5675 and after, Vulkan and OpenGL render incorrectly the background.

BAD 1 RPCS3 After Vulkan.log.gz

w/ WCB enabled it solves a part of the issue, forcing CPU Blit doesn't help. BAD 2 RPCS3 Vulkan WCB.log.gz

OpenGL + WCB throws an error. F {RSX [0x00cb378]} RSX: class std::runtime_error thrown: Assertion failed: src != nullptr (in file c:\projects\rpcs3\rpcs3\emu\rsx\common\texture_cache_utils.h:1403) RPCS3 OpenGL WCB.log.gz

kd-11 commented 5 years ago

New build here https://ci.appveyor.com/project/kd-11/rpcs3/builds/23107321/artifacts. Retest.

EDIT: This build has a crash bug, check my next message below.

MSuih commented 5 years ago

Yakuza 4 OpenGL crash is fixed, but the graphical issues described in my first message affect both APIs.

kd-11 commented 5 years ago

Disregard last build if getting crashes; use this build instead https://ci.appveyor.com/project/kd-11/rpcs3/builds/23108496

MsDarkLow commented 5 years ago

New build here https://ci.appveyor.com/project/kd-11/rpcs3/builds/23107321/artifacts. Retest.

With this build, Rogue Legacy seems to render everything correctly again. Both OpenGL and Vulkan

MarioSonic2987 commented 5 years ago

MCLA pink reflections bug with Vulkan and black reflection bug and crash with WCB with OpenGL are now fixed.

In Resident Evil 6, there's no flickering but reduces performance by spamming in console:

E {RSX [0x018ebe0]} RSX: [vulkan] vk::wait_for_event has timed out!

image With OpenGL, it's normal. image

kd-11 commented 5 years ago

Thanks for confirming the timeout bug, I'm investigating.

kd-11 commented 5 years ago

This build should fix the events timing out with vulkan.

MarioSonic2987 commented 5 years ago

It no longer spams in console and performance returns to normal. image

MarioSonic2987 commented 5 years ago

Worms Crazy Golf and Worms Revolution with Vulkan crash after starting up with this line thrown in console:

F {RSX [0x0102f34]} RSX: class std::runtime_error thrown: Verification failed (e=0x7f): 
(in file c:\projects\rpcs3\rpcs3\emu\rsx\vk\vktexturecache.h:300)

With OpenGL, it's fine.

Edit: They don't crash with CPU blit.

Log WCG VK Broken Log WCG GL

kd-11 commented 5 years ago

Should be fixed by https://ci.appveyor.com/project/kd-11/rpcs3/builds/23114644

MarioSonic2987 commented 5 years ago

Both games still don't work. Throws in console:

·F 0:00:13.090633 {RSX [0x0103fb4]} RSX: class std::runtime_error thrown: Verification failed (e=0x7f): 
(in file c:\projects\rpcs3\rpcs3\emu\rsx\vk\vktexturecache.h:310)

Log WCG VK Broken Log WCG VK Master

Now Beyond Two Souls no longer requires CPU blit to show proper textures.

Before/After ![](https://cdn.discordapp.com/attachments/272875751773306881/556233686660415499/unknown.png) ![image](https://user-images.githubusercontent.com/20027681/54464972-365a1900-4779-11e9-9ef6-14a97272a845.png)
uaqlover commented 5 years ago

rpcs3-v0.0.0.6-7879-5d7b41a3_win64

fixed Monster Jam_ Path of Destruction [BLUS30561]

FPS_ 17 04 _ Vulkan _ 0 0 6-7879 _ Monster Jam_ Path of Destruction  BLUS30561  15_03_2019 3_36_07 PM

but it show yellow when i stop the car

FPS_ 17 04 _ Vulkan _ 0 0 6-7879 _ Monster Jam_ Path of Destruction  BLUS30561  15_03_2019 3_36_48 PM

uaqlover commented 5 years ago

also it's stable now NASCAR® Unleashed [BLUS30806] not crashing

and Surf's Up [BLES00083] broke and flickering again

FPS_ 29 96 _ Vulkan _ 0 0 6-7879 _ Surf's Up  BLES00083  15_03_2019 3_56_12 PM

FPS_ 29 96 _ Vulkan _ 0 0 6-7879 _ Surf's Up  BLES00083  15_03_2019 3_57_32 PM

master

FPS_ 29 98 _ Vulkan _ 0 0 6-7869 _ Surf's Up  BLES00083  15_03_2019 4_03_37 PM

FPS_ 29 98 _ Vulkan _ 0 0 6-7869 _ Surf's Up  BLES00083  15_03_2019 4_03_57 PM

uaqlover commented 5 years ago

Ben 10™ Galactic Racing [BLUS30822]

error is gone but still has black textures ingame

FPS_ 29 96 _ OpenGL _ 0 0 6-7879 _ Ben 10™ Galactic Racing  BLUS30822  15_03_2019 4_11_55 PM

FPS_ 29 96 _ OpenGL _ 0 0 6-7879 _ Ben 10™ Galactic Racing  BLUS30822  15_03_2019 4_11_57 PM

same is rio has black textures

uaqlover commented 5 years ago

Skydive: Proximity Flight [NPUB30618] is broke

FPS_ 333 67 _ Vulkan _ 0 0 6-7879 _ Skydive_ Proximity Flight  NPUB30618  15_03_2019 4_29_20 PM

Shoot Many Robots (Demo) [NPUB30600] is still dark

FPS_ 30 03 _ Vulkan _ 0 0 6-7879 _ Shoot Many Robots (Demo)  NPUB30600  15_03_2019 4_55_26 PM

Emulator-Team-2 commented 5 years ago

@uaqlover Kung Fu Panda 2 requires to enable "Disable Vertex Cache" to fix this issue. Stop spamming with unrelated issues.

uaqlover commented 5 years ago

thanks @Emulator-Team-2 and sorry for posting unrelated issues

uaqlover commented 5 years ago

this pr fix's all pes series games

pr

FPS_ 60 11 _ Vulkan _ 0 0 6-7879 _ Pro Evolution Soccer 2010  BLUS30404  15_03_2019 6_24_19 PM

master

FPS_ 59 93 _ Vulkan _ 0 0 6-7869 _ Pro Evolution Soccer 2010  BLUS30404  15_03_2019 6_29_13 PM