RPCSX / rpcsx

GNU General Public License v2.0
1.23k stars 58 forks source link

cmake: try system xbyak first #32

Closed abouvier closed 1 year ago

abouvier commented 1 year ago

And regroup 3rdparty configuration in its own CMakeLists.txt.

DHrpcs3 commented 1 year ago

Why we should use system xbyak if possible? It is header only library, so no dependencies like .so files

abouvier commented 1 year ago

Because it simplifies packaging. You can reuse system headers instead of recursively updating every submodule in each repo. You can also build rpcsx from a zip download, so with an empty xbyak directory.

DHrpcs3 commented 1 year ago

Use git or download compiled binaries instead. We should prefer our clone of xbyak