search

RPCSX / rpcsx

GNU General Public License v2.0
1.23k stars 58 forks source link

Fixing fedora #45

Closed ryzendew closed 1 year ago

ryzendew commented 1 year ago

This change fixes a compile issue with cmake on fedora 38

here was the error image

gilcel commented 1 year ago

Thanks! Your PR fixes compilation on OpenSUSE Tumbleweed too, which gave the same error (compiled with gcc v13.1.1)

[ 86%] Linking CXX executable ../bin/rpcsx-os
/usr/lib64/gcc/x86_64-suse-linux/13/../../../../lib64/crt1.o: in function `_start':
/home/abuild/rpmbuild/BUILD/glibc-2.37/csu/../sysdeps/x86_64/start.S:103:(.text+0x2b): failed to convert GOTPCREL relocation against 'main'; relink with --no-relax
collect2: error: ld returned 1 exit status
make[2]: *** [rpcsx-os/CMakeFiles/rpcsx-os.dir/build.make:487: bin/rpcsx-os] Error 1
make[1]: *** [CMakeFiles/Makefile2:425: rpcsx-os/CMakeFiles/rpcsx-os.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
thealidev commented 1 year ago

so why don't anyone merge pull request

Nekotekina commented 1 year ago

This change is wrong.

thealidev commented 1 year ago

oh ok i am sorry