search

RPGHacker / asar

(Now) official repository of the SNES assembler Asar, originally created by Alcaro
Other
199 stars 42 forks source link

strange label bug! #230

Open gizaha opened 2 years ago

gizaha commented 2 years ago

It doesn't accept .9dac sublabel, it gives error in compiling rom (without saying what error) It accepts .9daC it accepts 8dac, but no .9dac

Main label is main: so problematic sublabel is main_9dac (Asar 1.81)

randomdude999 commented 2 years ago

hm, that does seem strange. i can't seem to reproduce it right now. can you reproduce it when applying the patch on an empty file, and if so, could you send a full patch file that reproduces it?

gizaha commented 2 years ago

In a new file i can't reproduce it either. It's not easy to sent the problematic file, i must sent you too many of others (too many depedencies and assets thrown at my pc). Anyway, i did it 9daC with capital C, lets ignore it.

p4plus2 commented 2 years ago

There is a bug fix in 2.0 where sometime labels not found could cause a phantom error. I will make sure to backport that to 1.9, in the mean time, that means this bug was (probably) the result of missing label (such as case sensitivity).

I'll leave this issue open as a reminder for me to backport the changes.

gizaha commented 2 years ago

I found it, sublabel was redefined later and the second one was inside a namespace, that's why it didn't tell me the type of error (redefined).

On Fri, Jan 14, 2022 at 3:15 AM p4plus2 @.***> wrote:

There is a bug fix in 2.0 where sometime labels not found could cause a phantom error. I will make sure to backport that to 1.9, in the mean time, that means this bug was (probably) the result of missing label (such as case sensitivity).

I'll leave this issue open as a reminder for me to backport the changes.

— Reply to this email directly, view it on GitHub https://github.com/RPGHacker/asar/issues/230#issuecomment-1012661200, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKWMIZEY7OGSIHEGVNUA3PLUV52LPANCNFSM5L4677XQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>