search

RPGHacker / asar

(Now) official repository of the SNES assembler Asar, originally created by Alcaro
Other
195 stars 42 forks source link

Trailing comma after `db` statement lacks helpful error #290

Closed bropedio closed 6 months ago

bropedio commented 9 months ago

Apologies if there is a better place for me to report this, but I ran into the following nonspecific error when compiling today (with verbose option)

Asar 1.90pre, originally developed by Alcaro, maintained by Asar devs.
Source code: https://github.com/RPGHacker/asar
Errors were detected while assembling the patch. Assembling aborted. Your ROM has not been modified.
Asar 1.90pre, originally developed by Alcaro, maintained by Asar devs.
Source code: https://github.com/RPGHacker/asar

Assembling completed without problems.

The ROM was not assembled, despite the final log output. The error turned out to be a trailing comma after a db statement.

  dw $812B : db "Attack",$00,
p4plus2 commented 9 months ago

We've been unable to replicate the issue. Can you provide additional context?

If you're using a batch script have you tried manually patching? It seems like the contents of stderr are being masked.

Alcaro commented 9 months ago

Reduced testcase to \<trillian> !rb as2 -b master db test: \<randombot999> Errors occurred while assembling.

Nothing to do with the comma.

(Doesn't even throw a phantom error, which may be a separate bug...) e: no it's not, phantom errors are only reported properly in 2.0

randomdude999 commented 6 months ago

fixed in 4cfb07217a38e8decd60ee72c476d529713340a7