search

RPGHacker / asar

(Now) official repository of the SNES assembler Asar, originally created by Alcaro
Other
195 stars 42 forks source link

src/asar: fix -Wmisleading-indentation warnings #308

Closed orbea closed 5 months ago

orbea commented 5 months ago

These macros are impossible to read and cause extremely verbose -Wmisleading-indentation warnings.

p4plus2 commented 5 months ago

A lot of these won't (or already don't) apply to the 2.0, but no reason to not fix them in 1.9 in the meantime. Thanks for the PR

If you're interested we do have a discord channel on sneslab for asar development and discussion. https://discord.com/invite/jh5Ry77N

orbea commented 5 months ago

A lot of these won't (or already don't) apply to the 2.0, but no reason to not fix them in 1.9 in the meantime.

Should I be making PRs against the asar_2_beta branch?

p4plus2 commented 5 months ago

Bug fixes and cleanup are acceptable in 1.9, but any features should belong in 2.0. But as a fair warning it is undecided whether 1.9 will see another release (though i suspect a 1.9.1 will happen)

2.0 is overall a long way from complete but initial cleanup and improvements are moving in the right direction. I'd also estimate 2.0 is roughly 3-4x faster than 1.9 at this time if you're working on large projects.