RPTools / maptool

Virtual Tabletop for playing roleplaying games with remote players or face to face.
http://rptools.net
GNU Affero General Public License v3.0
794 stars 260 forks source link

Scroll bar overlaps content in frame5/dialog5 #1905

Open mrkwnzl opened 4 years ago

mrkwnzl commented 4 years ago

Describe the bug In a frame5/dialog5, the scrollbar overlaps the content, if that content uses 100% of the width. This becomes apparent, when using tables set to width: 100%. The scrollbar disappears after a short time of idleness, but comes right back when I move the mouse. I suspect it has something to do with that.

Here is a screenshot of it happening with my character sheet:

Screen Shot 2020-05-21 at 19 35 07

Here is the same character sheet in version 1.7.0:

Screen Shot 2020-05-21 at 19 35 45

I also attached a campaign file with a similar, but reduced setup.

To Reproduce Steps to reproduce the behavior:

  1. Open the attached campaign file “Test table_develop 2020-05-21”
  2. Use the macros “Test table dialog5” or “Test table frame5”. Make sure the window has a height low enough to show the scrollbar.
  3. See that the scrollbar overlaps the right edge of the tables.

Expected behavior I expect the scrollbar not to overlap the table, as it does in v1.7.0.

MapTool Info

Desktop (please complete the following information):

Additional context Test table_develop 2020-05-21.cmpgn.zip

Phergus commented 4 years ago

Same thing seen in Windows. Probably some new feature in Java 14 with the fade-in/-out scrollbar or an old one that is now enabled by default.

Azhrei commented 4 years ago

On macOS, it's been like this for the last few operating system releases for all applications. The scrollbar fades from view when not in use. I guess the idea was to present a cleaner interface to the user for the 99% of the time that the user isn't scrolling. (Personally, I find it a pain because it makes the scrollbar difficult to grab with the mouse sometimes.)

It's interesting that it's extended to Windows now via JDK14...

mrkwnzl commented 4 years ago

The scrollbar in macOS is considerable less intrusive, as it only appears when scrolling. The scrollbar in MapTool (develop) appears with mouse movement. The fade out is actually pretty useless right now, as I’m constantly moving the mouse.

@Azhrei You can set the scrollbar in macOS to be always shown. System Preferences > General > Show scroll bars > Always. That should make it easier to grab the the scrollbar with the mouse.

Azhrei commented 4 years ago

You first said this:

Describe the bug In a frame5/dialog5, the scrollbar overlaps the content, if that content uses 100% of the width. This becomes apparent, when using tables set to width: 100%. The scrollbar disappears after a short time of idleness, but comes right back when I move the mouse.

And then you said this:

The scrollbar in macOS is considerable less intrusive, as it only appears when scrolling.

So what makes the macOS scroll bar less intrusive if both are only present when scrolling? (Sorry, I'm just looking at your screen shots and have not installed MT 1.7, so I'm only going off of what you've written.)

@Azhrei You can set the scrollbar in macOS to be always shown. System Preferences > General > Show scroll bars > Always. That should make it easier to grab the the scrollbar with the mouse.

Cool, I'll check that out. Thanks for the tip. :)

mrkwnzl commented 4 years ago

In MapTool, the scrollbar appears when I move the mouse curser, even when I’m not actually scrolling. In macOS, the scrollbar only appears when I’m actually scrolling, not when I move the mouse curser.

So in MapTool, it’s there basically all the time (which would be okay, if it wouldn’t overlap with the content). In macOS, it’s there basically none of the time.

Phergus commented 4 years ago

That's weird. It only shows up under Windows when the mouse is actually over the window.

mrkwnzl commented 4 years ago

That's weird. It only shows up under Windows when the mouse is actually over the window.

Oh, yeah, sorry. That’s true on macOS as well.

mrkwnzl commented 4 years ago

I’ve made a short screen recording. I hope it becomes more clear with that.

Demo Scrollbar MT vs macOS.mov.zip

JamzTheMan commented 4 years ago

It's interesting that it's extended to Windows now via JDK14...

Not really considering WebView is using webkit....

Azhrei commented 4 years ago

It's interesting that it's extended to Windows now via JDK14...

Not really considering WebView is using webkit....

And WebKit is an Apple product... That’s what I was referring to: “it’s interesting that <Apple’s idea of how the GUI should work> has extended to Windows via JDK14.”

JamzTheMan commented 4 years ago

It's more for Android than anything. The scrollbar fades out after scrolling with your thumb. Works well for the phone, I'm torn if I like it on the PC...

With that said, there is a webkit option to turn it on/off for webkit. I was looking to see if there is a CSS way to do it, none of the ::web-kit options seem to work well. Maybe a CSS wizard can figure it out?

Tdue21 commented 2 years ago

In danger of being accused of necromancy, this is still an issue in 1.12.