RPTools / maptool

Virtual Tabletop for playing roleplaying games with remote players or face to face.
http://rptools.net
GNU Affero General Public License v3.0
784 stars 259 forks source link

MapTool hangs when using HTML5 with CJK input sources on macOS #2635

Open fw opened 3 years ago

fw commented 3 years ago

Describe the bug MapTool suddenly hanged up when using HTML5 features with Japanese input sources (and other CJK input sources) on macOS.

To Reproduce Steps to reproduce the behavior:

  1. Open System Preferences on macOS.
  2. Launch Keyboard contained the System Preferences.
  3. Choose Input Source tab within the Keyboard.
  4. Add Japanese language.
  5. Check the Show Input menu in menu bar (Probably, it is default).
  6. Run MapTool. And run a macro using frame5 with button ([frame5('test'):{<button>Push</button>}]).
  7. Select Hiragana, Katakana or Romaji within input source in menubar at macOS. It can select when click flag of U.S. in menu bar.
  8. Click the button some times (probably up to ten times).
  9. MapTool hanged with getting the Spinning Wheel.

keyboard-preferences-on-mac

selecting-input-sources-on-mac

MapTool Info

Desktop (please complete the following information):

Additional context

Phergus commented 3 years ago

Was there any info in the log file?

fw commented 3 years ago

@Phergus Thanks for reply. I found a log file named maptool.log in ~/.maptoo-rptools/logs. Is it that? Or is it in other location? This contained bellow:


2021-05-23 19:16:01.183 INFO  net.rptools.maptool.client.MapTool - ********************************************************************************
2021-05-23 19:16:01.407 INFO  net.rptools.maptool.client.MapTool - **                                                                            **
2021-05-23 19:16:01.408 INFO  net.rptools.maptool.client.MapTool - **                              MapTool Started!                              **
2021-05-23 19:16:01.409 INFO  net.rptools.maptool.client.MapTool - **                                                                            **
2021-05-23 19:16:01.409 INFO  net.rptools.maptool.client.MapTool - ********************************************************************************
2021-05-23 19:16:01.410 INFO  net.rptools.maptool.client.MapTool - AppHome System Property: /Users/fowz/.maptool-rptools/logs
2021-05-23 19:16:01.410 INFO  net.rptools.maptool.client.MapTool - Logging to: /Users/fowz/.maptool-rptools/logs/maptool.log
2021-05-23 19:16:01.411 INFO  net.rptools.maptool.client.MapTool - getting MapTool version from manifest: 1.9.0-beta.2
2021-05-23 19:16:01.411 INFO  net.rptools.maptool.client.MapTool - getting MapTool vendor from manifest:  RPTools
2021-05-23 19:16:01.510 INFO  net.rptools.maptool.client.MapTool - argument passed via command line: -v=1.9.0
2021-05-23 19:16:01.511 INFO  net.rptools.maptool.client.MapTool - overriding MapTool version from command line to: 1.9.0
2021-05-23 19:16:01.511 INFO  net.rptools.maptool.client.MapTool - MapTool vendor: RPTools
2021-05-23 19:16:03.101 INFO  net.rptools.maptool.client.AppSetup - Installing ui theme: /Users/fowz/.maptool-rptools/themes/ui/Default.theme
2021-05-23 19:16:03.103 INFO  net.rptools.maptool.client.AppSetup - Installing ui theme: /Users/fowz/.maptool-rptools/themes/ui/RT_Default_Dark.theme
2021-05-23 19:16:03.104 INFO  net.rptools.maptool.client.AppSetup - Installing ui theme: /Users/fowz/.maptool-rptools/themes/ui/MT_Flat_Green_Sans_13.theme
2021-05-23 19:16:03.105 INFO  net.rptools.maptool.client.AppSetup - Installing ui theme: /Users/fowz/.maptool-rptools/themes/ui/RT_Flat_Default_Green.theme
2021-05-23 19:16:03.106 INFO  net.rptools.maptool.client.AppSetup - Installing ui theme: /Users/fowz/.maptool-rptools/themes/ui/TL_Golden_Sans_13.theme
2021-05-23 19:16:03.107 INFO  net.rptools.maptool.client.AppSetup - Installing ui theme: /Users/fowz/.maptool-rptools/themes/ui/TL_Forest_Sans_11.theme
2021-05-23 19:16:03.108 INFO  net.rptools.maptool.client.AppSetup - Installing ui theme: /Users/fowz/.maptool-rptools/themes/ui/TL_Forest_Sans_13.theme
2021-05-23 19:16:03.109 INFO  net.rptools.maptool.client.AppSetup - Installing ui theme: /Users/fowz/.maptool-rptools/themes/ui/TL_Golden_Sans_11.theme
2021-05-23 19:16:03.331 INFO  net.rptools.maptool.client.AppUpdate - Implementation-Version from Manifest: 1.9.0-beta.2
2021-05-23 19:16:03.332 INFO  net.rptools.maptool.client.AppUpdate - Cleaned version: 1.9.0.2
Phergus commented 3 years ago

That's it though no error were reported. Is that after MapTool has locked up?

fw commented 3 years ago

Yes. I first removed the log file then launched MapTool.

fw commented 3 years ago

I guess that the link bellow is related to this issue.

https://bugs.openjdk.java.net/browse/JDK-8241709

Using JavaFX Webview via JFXPanel in Swing, the application freezes on the selection of the keyboard layout (input source) such as Japanese in Mac OSX. It works fine with other keyboard layouts such as US international.

If MapTool uses Swing and WebView, I look like two are very similar.

Phergus commented 3 years ago

That is how MT is using JFX so it is likely the source of the issue. The issue you reference points out that it is a duplicate of https://bugs.openjdk.java.net/browse/JDK-8221261 which is scheduled for a Java 17 fix.

fw commented 3 years ago

Thank you for the information. I understood. I will wait to use HTML5 macros untill MapTool include Java 17.