RPTools / maptool

Virtual Tabletop for playing roleplaying games with remote players or face to face.
http://rptools.net
GNU Affero General Public License v3.0
800 stars 262 forks source link

Add read timeouts to server sockets #4805

Closed kwvanderlinde closed 5 months ago

kwvanderlinde commented 5 months ago

Identify the Bug or Feature request

Fixes #774

Description of the Change

On the server side, sockets now have a 1 minute read timeout. This gives plenty of time for heartbeats to come in and "reset" the timeout, while not allowing the server to hold onto stale connections forever.

Possible Drawbacks

I guess if the network is really haywire this could lead to forced disconnects.

Documentation Notes

Connections to servers automatically time out after one minute.

Release Notes


This change is Reviewable