search

RPTools / maptool

Virtual Tabletop for playing roleplaying games with remote players or face to face.
http://rptools.net
GNU Affero General Public License v3.0
800 stars 262 forks source link

[Bug]: A few dialogs can't be closed via escape key #4833

Closed kwvanderlinde closed 1 month ago

kwvanderlinde commented 5 months ago

Describe the Bug

Most of MapTool's modal dialogs can be closed via the escape key, but these few cannot:

To Reproduce

  1. Use any of the mentioned menu items to open a dialog.
  2. Hit the escape key
  3. Nothing happens.

Expected Behaviour

Using the escape key should consistently close dialogs

Screenshots

No response

MapTool Info

1.13.2, develop

Desktop

Linux Mint 21.3

Additional Context

No response

bubblobill commented 1 month ago

Preferences has no cancel option. All preferences are updated in real time. Cancelling would be a major rewrite of our most complicated dialog as it would require storing everything and committing changes on okay. Not going to touch it. Both other menu items refer to the same dialog. Have added close on escape to those ones.

kwvanderlinde commented 1 month ago

Ah, I never even thought of it as related to cancelling - the Preferences dialog could just close despite having committed changes. But I can also see how that might cause surprises.