search

RPTools / maptool

Virtual Tabletop for playing roleplaying games with remote players or face to face.
http://rptools.net
GNU Affero General Public License v3.0
787 stars 259 forks source link

VBL Excluding #4838

Open ColdAnkles opened 3 months ago

ColdAnkles commented 3 months ago

Identify the Bug or Feature request

closes #4836

Description of the Change

Unfinished Implementation of VBL Excluding per token. Needs review by someone who knows vision systems better

Possible Drawbacks

Forces frequent regeneration of Vision Areas - performance detriment

Documentation Notes

Adds macro functions to get and set map and token VBL immunity on a token. When set, that token's vision is not effected by that map/token topology.

Release Notes

Added ability for token to ignore specific topology.

This change is Reviewable

cwisniew commented 3 months ago

@kwvanderlinde do you wish to have a go at reviewing this as you have had your head in the code in this area more recently than I have? If you don't have time I can do it.

kwvanderlinde commented 3 months ago

Yeah I'll have a look. Though I think this could use some discussion at the feature level - it's related to a bunch of other FRs that are better backed by use cases, so I'd like to see how it works together with some of those other ideas.

I'll try to get some of that discussion going soon.

ColdAnkles commented 3 days ago

At this point, this is probably the best I can do with this. I think it's usable (or salvageable) as is - aside from the ugly GUI bits.