search

RPTools / maptool

Virtual Tabletop for playing roleplaying games with remote players or face to face.
http://rptools.net
GNU Affero General Public License v3.0
796 stars 260 forks source link

[Bug]: Macro Editor Themes not created on new installs. #4881

Open FullBleed opened 2 months ago

FullBleed commented 2 months ago

Describe the Bug

On new installs the Macro Editor Theme files are not created in the data directory "theme\syntax" directory. This means you can not select a Macro Editor Theme in Preferences.

To Reproduce

1) Run MT so that it creates a new data directory (you can delete or rename the existing directory or set a new data directory path in the maptool.cfg file.) 2) Then load MT and goto Edit>Preferences>Themes and try to set the Macro Editor Theme. The drop box will be empty and you will not be able to select a theme. 3) Check the new data directory theme/syntax folder and you will see that the themes for the Macro Editor are missing.

These are the files that should be in the directory: https://github.com/RPTools/maptool/tree/develop/src/main/resources/net/rptools/maptool/client/ui/syntax/themes

Expected Behaviour

The theme/syntax folder in the data directory should be populated with selectable themes when MapTool is run the first time (when it creates the data directory.)

Screenshots

No response

MapTool Info

1.15

Desktop

Window 11

Additional Context

Issue appears to have begun in 1.14.

bubblobill commented 4 weeks ago

I question why the macro editor is following the old themes which we presumably did away with for a reason. Would it not be more appropriate to update the editor to follow the user theme properly?