RPTools / maptool

Virtual Tabletop for playing roleplaying games with remote players or face to face.
http://rptools.net
GNU Affero General Public License v3.0
787 stars 259 forks source link

Reduce number of interfaces scanned for UPnP gateways #4904

Closed kwvanderlinde closed 2 weeks ago

kwvanderlinde commented 2 weeks ago

Identify the Bug or Feature request

Addresses #4902

Description of the Change

This changes the UPnP discovery logic to avoid network interfaces with no associated IP address. The goal is to reduce the number of devices that the UPnP scan has to wait for.

An additional change is to remove the dialogs displaying the specific interfaces in favour of a static glass pane that indicates UPnP setup is ongoing. The interfaces will still be logged, so they can be found for future reference if needed.

On my main Windows machines, this reduced the number of interfaces from ~12 to 2, with both remaining interfaces being legitimate possibilities for UPnP.

Possible Drawbacks

None

Documentation Notes

N/A

Release Notes


This change is Reviewable