RPTools / maptool

Virtual Tabletop for playing roleplaying games with remote players or face to face.
http://rptools.net
GNU Affero General Public License v3.0
787 stars 259 forks source link

[Bug]: Token Light Source popup menu items for clearing Light or Auras are duplicated if multiple tokens selected #4933

Closed Baaaaaz closed 1 day ago

Baaaaaz commented 1 week ago

Describe the Bug

"Clear [Owner/GM] Light/Aura" token popup menu items are duplicated if multiple tokens have these lights/auras and are selected.

To Reproduce

  1. Create a token and given it a variety of lights and auras (inc. Owner or GM types)
  2. Copy and paste the token several times.
  3. Select all the tokens
  4. Bring up the token popup menu and observe duplicated Light Source menu items for clearing lights/auras.
  5. Clicking one of these duplicated menu items with clear all appropriate lights/auras of the type clicked from all the selected tokens.

Expected Behaviour

Popup menu items are not duplicated.

Screenshots

image

MapTool Info

1.15.0

Desktop

No response

Additional Context

https://github.com/RPTools/maptool/issues/4927 already raised for incorrect GUI text.

kwvanderlinde commented 1 day ago

Same cause: if you have a bunch of tokens selected, some with lights and some without: