After selected the "Set Facing" tool from the token's context menu, an NPE is generated if the mouse is clicked (ending the operation) without moving the cursor (not setting a facing).
I found this in 1.15.2, but expect it has existed for a long time.
To Reproduce
Open a new campaign and drop any token on the map.
Make sure it does not have a facing, i.e., there is no yellow arrow
Right-click the token and select "Set Facing".
Being careful not to move the mouse, click the map to end the "Set Facing" operation.
An error dialog should come up with the NPE.
Expected Behaviour
If the mouse hasn't moved, the "Set Facing" operation should do nothing.
Screenshots
No response
MapTool Info
MapTool 1.15.2
Desktop
Linux Mint 22
Additional Context
Here is the error:
java.lang.NullPointerException: Cannot invoke "java.lang.Integer.intValue()" because the return value of "net.rptools.maptool.model.Token.getFacing()" is null
at net.rptools.maptool.client.tool.FacingTool.mousePressed(FacingTool.java:172)
at java.desktop/java.awt.AWTEventMulticaster.mousePressed(AWTEventMulticaster.java:288)
at java.desktop/java.awt.Component.processMouseEvent(Component.java:6618)
at java.desktop/javax.swing.JComponent.processMouseEvent(JComponent.java:3398)
at java.desktop/java.awt.Component.processEvent(Component.java:6386)
at java.desktop/java.awt.Container.processEvent(Container.java:2266)
at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:4996)
at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2324)
at java.desktop/java.awt.Component.dispatchEvent(Component.java:4828)
at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4948)
at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Container.java:4572)
at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Container.java:4516)
at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2310)
at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2780)
at java.desktop/java.awt.Component.dispatchEvent(Component.java:4828)
at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:775)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:720)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:714)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:87)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:98)
at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:747)
at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:87)
at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:744)
at net.rptools.maptool.client.swing.MapToolEventQueue.dispatchEvent(MapToolEventQueue.java:54)
at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)
Describe the Bug
After selected the "Set Facing" tool from the token's context menu, an NPE is generated if the mouse is clicked (ending the operation) without moving the cursor (not setting a facing).
I found this in 1.15.2, but expect it has existed for a long time.
To Reproduce
Expected Behaviour
If the mouse hasn't moved, the "Set Facing" operation should do nothing.
Screenshots
No response
MapTool Info
MapTool 1.15.2
Desktop
Linux Mint 22
Additional Context
Here is the error: