Fix NPE in Set Facing tool - Githubissues

RPTools / maptool

Virtual Tabletop for playing roleplaying games with remote players or face to face.

http://rptools.net

GNU Affero General Public License v3.0

800 stars 262 forks source link

Fix NPE in Set Facing tool #4957

Closed kwvanderlinde closed 1 month ago

kwvanderlinde commented 1 month ago

Identify the Bug or Feature request

Fixes #4956

Description of the Change

The Set Facing tool now handles the case where a token has no facing at the end of the operation (see changes in FacingTool.mousePressed()).

The rest of the changes are easy cleanup related to facing, but don't affect functionality:

Use Token.hasFacing() instead of Token.getFacing() == null
Use Token.getFacingInDegrees() where it helps.
Provide Token.removeFacing() to clear facing rather than using Token.setFacing(null).
Move the default -90° angle into Token.getFacing()
Remove all nullability of facing in Token's API.

Possible Drawbacks

None

Documentation Notes

N/A

Release Notes

Fixed a bug where the Set Facing tool would throw an error if the mouse never moved.

This change is