search

RPTools / maptool

Virtual Tabletop for playing roleplaying games with remote players or face to face.
http://rptools.net
GNU Affero General Public License v3.0
790 stars 257 forks source link

[Bug]: Snap-to-grid and erase toggles are set per tool #5004

Open kwvanderlinde opened 17 hours ago

kwvanderlinde commented 17 hours ago

Describe the Bug

When using drawing and fog tools, we can set all sorts of things in the colour picker. When switch to a different drawing tool or different fog tools, the snap-to-grid and erase toggle buttons are cleared. If we switch back to the first tool, those buttons' states are restored. The rest of the controls are preserved when switch tools.

To Reproduce

  1. Select the rectange drawing tool.
  2. Change the colours and layers. Also toggle on all the buttons (snap-to-grid, erase, line type).
  3. Select the oval drawing tool.
  4. Notice the colour picker is the same, except the snap-to-grid and erase toggles are off now.
  5. Select the rectangle drawing tool again.
  6. Notice the colour picker is back to the state it was in (2).

Expected Behaviour

All colour picker state is preserved when switch tools.

Screenshots

No response

MapTool Info

1.15.2

Desktop

Linux Mint 22

Additional Context

No response

kwvanderlinde commented 17 hours ago

This behaviour looks like it was deliberately added (probably a long time ago). But I'm calling it a bug due to the inconsistency and surprise factor.