RPVote / eiCompare

Comparing ecological inference techniques
https://rpvote.github.io/voting-rights/
6 stars 7 forks source link

Release eiCompare 3.0 on CRAN #60

Open scottyhq opened 3 years ago

scottyhq commented 3 years ago

A checklist in prep of a new package release following https://r-pkgs.org/release.html#release-version

lorenc5 commented 3 years ago

Logo sounds like a great idea.

On Wed, Aug 5, 2020 at 4:43 PM Scott Henderson notifications@github.com wrote:

A checklist in prep of a new package release following https://r-pkgs.org/release.html#release-version

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DSSG-eiCompare/eiCompare/issues/60, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGKPEZTN56V6QWAD2QHOQLTR7HN73ANCNFSM4PV7LKJQ .

-- Loren Collingwood Associate Professor Department of Political Science University of California, Riverside collingwoodresearch.com

lorenc5 commented 3 years ago

loren.collingwood@gmail.com

scottyhq commented 3 years ago

@RPVote/fellows @lorenc5 - it'd be nice to have a concise example in the README.md that conveys what eiCompare does. Obviously this is hard given many possible workflows. Currently I can run vignettes/ei.Rmd but it takes ~1 min. And demo/demo.R gives an error running ei_bayes_res <- bayes_table_make(ei_bayes, cands, table_names):

Error in data.table::rbindlist(list_holder): Item 1 of input is not a data.frame, data.table or list
Traceback:

1. bayes_table_make(ei_bayes, cands, table_names)
2. data.table::rbindlist(list_holder)

Suggestions on 1 - 10 lines of code to put front and center in README.md?