search

RPi-Distro / pi-bluetooth

Loads BCM43430A1 firmware on boot
42 stars 34 forks source link

btuart: Make it work with busybox/sh #5

Closed kraj closed 6 years ago

kraj commented 6 years ago

Currently it fails with warnings when using busybox /bin/sh applet

Signed-off-by: Khem Raj raj.khem@gmail.com

pelwell commented 6 years ago

I like the short version, but I have no objection to merging this PR.

XECDesign commented 6 years ago

Are the $() to `` changes required? https://github.com/koalaman/shellcheck/wiki/SC2006

kraj commented 6 years ago

I was just trying to get the warnings addressed with busybox/ash I can try to use $() and see

kraj commented 6 years ago

If I change `` to $() I get back to this warning

warning: command substitution: ignored null byte in input
XECDesign commented 6 years ago

Sorry, I've just noticed `` is used elsewhere in the file as well, so we may as well be consistent.