RPi-Distro / pi-gen

Tool used to create the official Raspberry Pi OS images
BSD 3-Clause "New" or "Revised" License
2.58k stars 1.61k forks source link

FAT partition label: don't name it "boot" #669

Closed macmpi closed 1 year ago

macmpi commented 1 year ago

There is a quite maddening side effect of default boot partition label together with a longstanding firmware bug uncovered by @pelwell : https://github.com/raspberrypi/firmware/issues/1529#issuecomment-774102402

That partition naming prevents use of boot directory name inside it, for anything essential to boot the system from FAT partition... Not a major problem for PiOS but has adverse consequence for other distribution that may be installed after.

Agreed, root of problem is in firmware side, but as this does not seem to get resolved, here is a typical consequential use-case if default Pi OS image use that boot label.

All this because first-off media generation had that colliding boot label... definitely not an obvious guess!

Would it be possible to consider another non-colliding label name for that default FAT partition (FATboot or something), until that firmware bug is eventually fixed?

XECDesign commented 1 year ago

@pelwell, @timg236, is this a bootrom issue on older pis, or can it be fixed in bootcode.bin or start.elf files?

pelwell commented 1 year ago

It's somewhere deep in the filesystem abstractions of start*.elf.

macmpi commented 1 year ago

thanks :+1:

XECDesign commented 1 year ago

Thanks for reporting the issue

macmpi commented 1 year ago

Hopefully firmware will get a permanent fix at some point, but at least one main source of catch-22 should be gone with next release. :wink: