search

RPi-Distro / pi-gen

Tool used to create the official Raspberry Pi OS images
BSD 3-Clause "New" or "Revised" License
2.57k stars 1.61k forks source link

Skip binfmt_misc register when unnecessary #693

Closed stefanb2 closed 1 year ago

stefanb2 commented 1 year ago

This improves commit 6dc45a80e764eacd6e311c32164b623bbe7f8e08

Check if interpreter is already registered before running the register step. This avoids unnecessary "sudo" execution which may require user interaction for the password.

Improves on #685

stefanb2 commented 1 year ago

@moh53n can you please check this as you are the author of the original PR?

stefanb2 commented 1 year ago

No idea what the || true is supposed to achieve, but restored it...

stefanb2 commented 1 year ago

FYI I also have a PR which adapts #685 for the arm64 branch, but GitHub is having issues right now...

moh53n commented 1 year ago

LGTM, Also, the || true part eliminates error when our interpreter is already registered (with the same name).

XECDesign commented 1 year ago

Thanks