fix: support bash v3 by removing array usage

RPi-Distro / pi-gen

Tool used to create the official Raspberry Pi OS images

BSD 3-Clause "New" or "Revised" License

2.57k stars 1.61k forks source link

fix: support bash v3 by removing array usage #705

Closed reubenmiller closed 11 months ago

reubenmiller commented 1 year ago

Improve compatibility of the docker-compose.yaml script by supporting bash v3. MacOS users only have bash v3 by default (due to licensing).

XECDesign commented 12 months ago

I'll leave this hanging for a little bit, since I'm not a Docker or MacOS user. Hoping that will give time for people who are to provide some feedback.

rhysackerman commented 11 months ago

I'll leave this hanging for a little bit, since I'm not a Docker or MacOS user. Hoping that will give time for people who are to provide some feedback.

Tested and it seemed to work fine for me. macOS Ventura, latest Docker version. Image generated fine, however failed on export due to running out of storage (my fault)

cjcdev commented 11 months ago

@XECDesign Did this commit break using "PRESERVE_CONTAINER=1 CONTINUE=1" ?