RPi-Distro / pi-gen

Tool used to create the official Raspberry Pi OS images
BSD 3-Clause "New" or "Revised" License
2.52k stars 1.58k forks source link

/usr/bin/raspi-config: 847: lxpanelctl: not found #761

Closed ampledata closed 4 months ago

ampledata commented 4 months ago

It looks like the addition of the call to lxpanelctl at https://github.com/RPi-Distro/raspi-config/commit/dd6647646a71c14664c951c59cc2fb27b8a55162 is causing pi-gen to fail at stage2/02-net-tweaks/01-run.sh

[23:59:17] End /home/gba/src/SNS/aryaos/pi-gen/stage2/02-net-tweaks/00-packages
[23:59:17] Begin /home/gba/src/SNS/aryaos/pi-gen/stage2/02-net-tweaks/01-run.sh
'files/wpa_supplicant.conf' -> '/home/gba/src/SNS/aryaos/pi-gen/work/aryaos-1.0.0-beta1/stage2/rootfs/etc/wpa_supplicant/wpa_supplicant.conf'
/usr/bin/raspi-config: 847: lxpanelctl: not found
make: *** [Makefile:18: build] Error 127

My pi-gen config:

IMG_NAME="aryaos-1.0.0-beta1"
PI_GEN_RELEASE="AryaOS"
TARGET_HOSTNAME="aryaos"
FIRST_USER_NAME="pi"
FIRST_USER_PASS="example"
STAGE_LIST="stage0 stage1 stage2 stage3-wifi"
DISABLE_FIRST_BOOT_USER_RENAME=1
RELEASE="bookworm"
WPA_COUNTRY="US"
LOCALE_DEFAULT="en_US.UTF-8"
KEYBOARD_LAYOUT="English (US)"
KEYBOARD_KEYMAP="us"
ENABLE_SSH=1

pi-gen is arm64@6fb311e7fb57b4e7980ae3270c25b569b19dfe8f

XECDesign commented 4 months ago

So what's making the if pgrep lxpanel check pass? Is it that you're running in on PiOS and since we bind /proc, it sees the host's lxpanel?

I guess raspi-config should additionally check whether it's running in a chroot environment in that case. But at this point, that's just a guess, since it's not failing to build in our CI system.

XECDesign commented 4 months ago

Is your debian host running lxde?

The check is in the commit you linked.

ampledata commented 4 months ago

Aye, my host is running LXDE.

XECDesign commented 4 months ago

Yeah, that would be it then. I'll update raspi-config.

XECDesign commented 4 months ago

If you do a clean build starting from stage0, I'm hoping it should work now.

ampledata commented 4 months ago

Looks good!