search

RPi-Distro / raspberrypi-sys-mods

A collection of Raspberry Pi-sourced system configuration files and associated scripts
99 stars 36 forks source link

Make Microsoft Repo optional #52

Closed lfuelling closed 3 years ago

lfuelling commented 3 years ago

Hi, this PR addresses #42, #43, #44, #49 and #50 (from what I can tell) and makes the configuration of the Microsoft Repo optional (opt-in as opposed to #51).

This also requires a new dependency: debconf

The key raspberrypi-sys-mods/setup_ms_repo is used to keep track of the users choice.

XECDesign commented 3 years ago

Duplicate of https://github.com/RPi-Distro/raspberrypi-sys-mods/pull/51

XECDesign commented 3 years ago

Apologies, not a duplicate, but closed for the same reason.

lfuelling commented 3 years ago

The reason being this?

Since our aim is to remove hurdles and make things simple for beginners who may not know what a repo is, requiring input like that is just confusing.

Well I don't want the Microsoft GPG key and Repo to be automatically installed on my grandmas video conferencing system. Seems like I have to go there during lockdown and risk her life to remove that garbage. Thank you so much for removing that hurdle.

XECDesign commented 3 years ago

Given that the repo doesn't do anything unless she chooses to install vs code, I'd advise against risking somebody else's life for your ideology.

lfuelling commented 3 years ago

So there is no request to Microsoft when the package update Cronjob runs? I must misunderstand how APT works then.

Given that your above statement is wrong and you don't really seem to care about any of this maybe you should change your profile pic to have four colors separated by a white cross instead of the hacker glider...

And yes, having control over where a system sends requests to is part of my ideology, otherwise I would have gotten her a Surface.

lfuelling commented 3 years ago

Also I think it's highly ridiculous that you expect users to use the raspy-config utility after the first boot but don't want to "confuse them" by showing them a dialog that looks exactly like the raspi-config utility.

I think that whole making stuff easier talk is just hiding some sponsorship...

lfuelling commented 3 years ago

Regarding this comment on #43: this PR would be GDPR compliant.

Also I can't really comprehend why a user who is confused by a simple Yes/No dialog would need VSCode.

FredericGuilbault commented 3 years ago

Looks like teaching VScode to users is part of their educative mission but not repo management. .... priorities I guess

starbasessd commented 3 years ago

For that matter, why not put it IN raspi-config? Start putting dev stuff in there? Or under the Preferences, Recommended Software? Or a link in "Programming, where the other learning Dev stuff is? Another specious argument on the part of RPiFoundation...

ArvoX commented 3 years ago

Given that the repo doesn't do anything unless she chooses to install vs code, I'd advise against risking somebody else's life for your ideology.

It dos. My internet connection is not the best ind the world an having an extra repo to check cost time i don't want to use. So it has an impact even if you can not see it!