search

RPi-Distro / raspi-config

Configuration tool for the Raspberry Pi
Other
565 stars 207 forks source link

Correct D6 menu item for Pi 4 #183

Closed ghost closed 2 years ago

ghost commented 2 years ago

The D6 menu item is currently labelled Composite Set options for composite output. On Pi 4 it also contains the option to enable/disable 4kp60 output, but when this option was added, the menu name and description were not updated. This PR adds the correct description on Pi 4, and leaves the description as it is on other Pis.

The reason for filing this PR is that someone complained on the forums about there being no visible option in raspi-config to enable 4kp60, and ended up hunting through the menus to find it.

I have tested these changes on both a Pi 4 and pi 3B, and they work as intended on both.

(Note that this is a rebirth of #180, required due to my previous lack of git skill).

XECDesign commented 2 years ago

@spl237 I suspect this is your area and you'll have thoughts on this.

spl237 commented 2 years ago

To be honest, this isn't an option we expect most people to use, which is why it is only in raspi-config and not in the GUI. The PR clashes with recent changes to raspi-config anyway, and the implementation is non-intuitive and does not match the way we have implemented other Pi4-specific menus in the script. So many thanks, but I'd prefer to leave things as they are in this case.

ghost commented 2 years ago

To be honest, this isn't an option we expect most people to use, which is why it is only in raspi-config and not in the GUI. The PR clashes with recent changes to raspi-config anyway, and the implementation is non-intuitive and does not match the way we have implemented other Pi4-specific menus in the script. So many thanks, but I'd prefer to leave things as they are in this case.

The implementation is completely different to other Pi 4-specific options because for this one there would otherwise be lots of duplication in the code. I don't understand the logic behind having an option that people cannot find, but I'm happy to accept that is your decision to make.