RPi-Distro / raspi-config

Configuration tool for the Raspberry Pi
Other
570 stars 209 forks source link

Honor of 'nonint' parameter inconsistent #189

Closed Jibun-no-Kage closed 2 years ago

Jibun-no-Kage commented 2 years ago

Attempting to invoke do_update one of two issues result. First, if the 'user' is not defined before execution of command, whiptail is invoked prompting for response from operator, this is never seen because typical use of the 'nonint' parameter strongly suggests the call to raspi-config is not interactive.

raspi-config nonint do_update

Second if the 'user' is defined, do_update is invoked, but given the script logic the UI is again invoked, post update, so whiptail again executes and waits forever for operator action... I strongly suggest this defeats the entire nature of the 'nonint' parameter as documented and explained by official documentation.

SUDO_USER=pi raspi-config nonint do_update

Please fix this. Moreover this issue is or would be obvious, if any basic testing was done with the said nonint parameter and invoking do_update. So there is a strong indication that basic QA/QC of the coding needs to be improved, addressed.

And, as a 30 year IT professional, where for years I did QA/QC validation of code logic, I also noticed that there is no version or release information in the script or even on the github page?


#!/bin/sh
# Part of raspi-config https://github.com/RPi-Distro/raspi-config
#
# See LICENSE file for copyright and license details
Jibun-no-Kage commented 2 years ago

(Odd formatting, so continued here)

Come guys, this not professional, how is a user to know they have the latest script even if they know about github and how to navigate in it. Even when embedded in the official OS image, the raspi-config script file should have basic version numbering and release date information. Please improve your process, your users will appreciate it.

If need examples of what is wrong, here is a link to the applicable raspberry ip forum discussion on this issue. https://forums.raspberrypi.com/viewtopic.php?p=1994902#p1994902

Jibun-no-Kage commented 2 years ago

Why was this closed?