search

RPi-Distro / repo

Issue tracking for the archive.raspberrypi.com repo
37 stars 1 forks source link

PcManFM: another %20 issue left #195

Closed beta-tester closed 4 years ago

beta-tester commented 4 years ago

@spl237 / Simon Long, i found one place left where the %20 issue in PCmanFM is present. when you copy a file with spaces in its filen ame to a samba share but the file already exists at the destination... then a dialog pops up for what to do (skip, overrider)... and there the file name in the file name field is still shown with %20 instead of a space.

its a follow up of the comments here: https://www.raspberrypi.org/blog/a-new-raspbian-update/#comment-1521860

pcmanfm-issue-x20

spl237 commented 4 years ago

I've just tried this with all my changes rolled out, and it still happens, so it looks as if it is an issue with upstream PCManFM or libfm - I'd suggest raising an issue with the original authors, as they are better placed to fix this. If I get a chance I'll see if I can see anything obvious, but it's not likely to be code I've looked at, so it'll be easier if the original authors can investigate.

spl237 commented 4 years ago

I've found a potential fix for this, which you are welcome to try (assuming you are happy to rebuild the relevant code yourself).

In the source code for libfm4, in the file src/gtk/fm-progress-dlg.c, change line 270 from:

 tmp = g_filename_display_name(fm_path_get_basename(path));

to

 tmp = g_filename_display_name(fm_path_display_basename(path));

This fixes the problem for me, but I don't know if it will lead to problems elsewhere, so any testing you can do would be appreciated!

beta-tester commented 4 years ago

@spl237 , hello Simon... I beg your pardon for that issue report...

you are right - i am wrong - debian HAS that issue as well. Screenshot from 2020-09-01 16-01-52

Screenshot from 2020-09-01 16-00-48

maybe i am blind or damaged... this issue has to be directed to the original authors. thank you for investigating your time.

spl237 commented 4 years ago

No problem - but if you get a chance, do try the fix above - I think it should work.

beta-tester commented 4 years ago

how can i test it... do i have to compile the libfm4 locally or can i download the fixed version somewhere?

spl237 commented 4 years ago

You'll have to build it locally:

apt source libfm sudo apt build-dep libfm cd libfm-1.3.1 ./configure --prefix=/usr --libdir=/usr/lib/arm-linux-gnueabihf

Make the code change as above and then:

make sudo make install

Reboot

beta-tester commented 4 years ago

i will prepare another RPi for building and testing... the RPi where i am on right now i will not reboot today. ... i will tell you later the result.

beta-tester commented 4 years ago

yes, your fix is working... thank you!

PS: will the sudo make install be overwritten when a new version of libfm will be published via regular apt update && apt full-upgrade ... or do i have to uninstall the modified version first?

spl237 commented 4 years ago

The version you have built will be overwritten with the next update from apt.

If you can carry on using it and let me know if you find any problems, that would be great - I think it should be safe to add to the version in apt, but it would be good for it to have some more testing first!

beta-tester commented 4 years ago

ok, i will carry on with this version and let you know when i see any related issue with it.

beta-tester commented 4 years ago

today i received an updated libfm and pcmanfm via apt... it is fixed now in the main stream or wasn't just my local modification been overwritten?

spl237 commented 4 years ago

Fixed in the updated version, which will have overwritten your locally-built version with an official release of exactly the same build...

beta-tester commented 4 years ago

thank you!